Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor tab for PR description is permanent i.e not in preview mode #113

Closed
ramya-rao-a opened this issue Jul 31, 2018 · 1 comment
Closed
Labels
description page feature-request Request for new features or functionality upstream/vscode

Comments

@ramya-rao-a
Copy link

ramya-rao-a commented Jul 31, 2018

Testing microsoft/vscode#55396 on Ubuntu

The description web view uses the non-preview mode of the editor tab and the file changes use the preview mode.

Say I have the description page open, then I click on one of the files to see the diff open in a new editor. When returning to the description page (that is already open), it is blank and there is a considerable lag in populating the page when the machine is seeing a high CPU usage

An already open tab gives the perception that all data for that editor is already loaded and we are just switching back and forth (even though thats not the case based on our implementation).

I would suggest that the PR description page also use the preview mode. This would solve the perception problem

@alexr00
Copy link
Member

alexr00 commented Nov 9, 2020

We are actually moving away from using as much preview mode with editors so I think it is fair to say that we will not change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description page feature-request Request for new features or functionality upstream/vscode
Projects
None yet
Development

No branches or pull requests

4 participants