Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GitHub Pull Request extension #55396

Closed
5 tasks done
RMacfarlane opened this issue Jul 30, 2018 · 0 comments
Closed
5 tasks done

Test GitHub Pull Request extension #55396

RMacfarlane opened this issue Jul 30, 2018 · 0 comments
Assignees
Milestone

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Jul 30, 2018

Refs: microsoft/vscode-pull-request-github#1

Complexity: 5

This is to test the GitHub PR extension. This extension is still in a preview state and has some obvious gaps:

  • Better auth flow still in progress
  • No multi-root folder support
  • No support for the GH Review flow
  • No explicit merge support

Please file any issues you run into in the extension's repository.

Setup

  • Download the latest visx from our release page
  • Install the vsix in latest Insider
  • Run Insider from command with flag code-insiders --enable-proposed-api Microsoft.vscode-pull-request-github

Authentication

There are two ways of doing authentication

  • GitHub access token, this is the recommended way right now. The config name is github.accessToken. Please make sure the token you put there has proper access to repo and user
  • If there is no GitHub access token, the extension will try to use the local Git Credential Manager. Whether the authentication will work depends on if your local credentials work.
    There is an known bug when you are using ssh and the passphrase expires, the extension will fail slightly.

Testing

Some things to try/verify:

Pull Request tree view:

  • View pull requests in SCM viewlet when a GitHub repository is opened in VSCode, the predefined categories work as expected.
  • View file changes from the Pull Request tree view and create comments within these.
  • View the description page for a pull request, the timeline events of a pull request are rendered properly.
  • Leave generic issue comments in the description page for a pull request.
  • Context menu for a pull request item, file change item in the tree view
  • If the repository contains many PRs, a load more button appears for the category within the tree and works as expected.

Review mode

  • Checkout to a pull request from Pull Request description page or content menu of Pull Request tree view works, the comments panel and additional "Changes in Pull Request" tree view shows up in the SCM viewlet.
  • Navigate through comments in the Command Panel.
  • View/Create comments in a normal editor.
  • Comments positions are adjusted when you make changes to local content.
  • The "Changes in Pull Request" view lists file changes and all commits in the PR.
  • After modifying/adding/deleting comments for the pull request on GitHub, comments within VSCode are updating to reflect this within a minute.
@RMacfarlane RMacfarlane added this to the July 2018 milestone Jul 30, 2018
This was referenced Jul 31, 2018
@ramya-rao-a ramya-rao-a removed their assignment Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants