Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute the Copy Permalink command to the Copy As submenu #2326

Closed
egamma opened this issue Dec 18, 2020 · 5 comments · Fixed by #2574
Closed

Contribute the Copy Permalink command to the Copy As submenu #2326

egamma opened this issue Dec 18, 2020 · 5 comments · Fixed by #2574
Assignees
Labels
feature-request Request for new features or functionality issues polish verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Dec 18, 2020

See the GitLens extension

@egamma egamma added this to the January 2021 milestone Dec 18, 2020
@alexr00 alexr00 added feature-request Request for new features or functionality issues polish labels Dec 21, 2020
@alexr00
Copy link
Member

alexr00 commented Dec 29, 2020

@eamodio would you be willing to rename the Gitlens "Copy As" submenu to just editor/context/copy?

https://github.com/eamodio/vscode-gitlens/blob/bbbbc017aa9fb258a3886e0300cb5c9b51f0c684/package.json#L8360-L8363

@eamodio
Copy link
Contributor

eamodio commented Dec 29, 2020

Sure, can do.

@eamodio
Copy link
Contributor

eamodio commented Dec 30, 2020

@alexr00 although in order for us to use editor/context/copy, core would need to add that as a built-in submenu -- otherwise we won't be able to target it. Because if we both attempt to contribute it either as a submenu or into editor/context it will error out, see below.

If we both attempt to contribute it as a submenu we will get the following error:
The editor/context/copy submenu was already previously registered

And if we both attempt to contribute the submenu to editor/context we will get the following error:
The editor/context/copy submenu was already contributed to the editor/context menu

@alexr00
Copy link
Member

alexr00 commented Dec 30, 2020

Hmm, as you say, looks like it should be added as a core menu. @joaomoreno is there a way to contribute a submenu in the core that only shows if it has items in it?

@joaomoreno
Copy link
Member

Unfortunately we decided to go with: an empty submenu still renders as empty. We can look into changing that or having a setting for it. cc @jrieken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality issues polish verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
6 participants