Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it very obvious when the rate limit has been hit #4546

Closed
alexr00 opened this issue Feb 20, 2023 · 1 comment · Fixed by #4610 or #4677
Closed

Make it very obvious when the rate limit has been hit #4546

alexr00 opened this issue Feb 20, 2023 · 1 comment · Fixed by #4610 or #4677
Assignees
@alexr00
Labels
feature-request Request for new features or functionality on-testplan
Milestone
April 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 20, 2023

#4523 indicated that we need a better early warning system than GitHub issues for when the rate limit is hit.

Some things to consider:

  • Telemetry when the rate limit is hit or when we detect many requests in a short time. I'm not sure how many GitHub Enterprise users have telemetry enabled, however.
  • Stop making requests if the rate seems too high.
@alexr00 alexr00 added the feature-request Request for new features or functionality label Feb 20, 2023
@alexr00 alexr00 added this to the March 2023 milestone Feb 20, 2023
@alexr00 alexr00 self-assigned this Feb 20, 2023
@kieferrm kieferrm mentioned this issue Mar 6, 2023
Closed
91 tasks
This was referenced Mar 9, 2023
Closed
Merged
alexr00 added a commit that referenced this issue Mar 10, 2023
@alexr00
Add an internal rate limit
2aced30 
Fixes #4546
alexr00 added a commit that referenced this issue Mar 10, 2023
@alexr00
Add an internal rate limit (#4610)
93129e3 
* Add an internal rate limit
Fixes #4546

* Fix some error/info messages
@alexr00 alexr00 mentioned this issue Mar 20, 2023
Closed
4 tasks
@alexr00 alexr00 modified the milestones: March 2023, April 2023 Mar 27, 2023
@alexr00
Copy link
Member Author

alexr00 commented Mar 27, 2023

Re-opening and moving to April due to revert caused by #4671

@alexr00 alexr00 reopened this Mar 28, 2023
@alexr00 alexr00 mentioned this issue Mar 28, 2023
Merged
alexr00 added a commit that referenced this issue Mar 28, 2023
@alexr00
Make it very obvious when the rate limit has been hit
54691eb 
Fixes #4546
@kieferrm kieferrm mentioned this issue Apr 2, 2023
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
April 2023
1 participant
@alexr00