Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments are not visible in reviews #6590

Closed
connor4312 opened this issue Jan 7, 2025 · 0 comments · Fixed by #6625
Closed

Comments are not visible in reviews #6590

connor4312 opened this issue Jan 7, 2025 · 0 comments · Fixed by #6625
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2025

Comments

@connor4312
Copy link
Member

  • Extension version: 0.103.2025010704
  • VSCode Version: Insiders
  • OS: vscode.dev

Steps to Reproduce:

  1. Go to a PR on insiders.vscode.dev, like https://insiders.vscode.dev/github/microsoft/vscode/pull/236967
  2. Leave a review comment or start a review
  3. image
@alexr00 alexr00 self-assigned this Jan 29, 2025
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 29, 2025
@alexr00 alexr00 added this to the January 2025 milestone Jan 29, 2025
alexr00 added a commit that referenced this issue Jan 30, 2025
@alexr00
Don't import TextDecoder
f1a1485 
Fixes #6590
This was referenced Jan 30, 2025
Merged
Closed
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Don't import TextDecoder microsoft/vscode-pull-request-github
3 participants
@connor4312 @eleanorjboyd @alexr00