Implement auth service switching for GitHub Enterprise #2468
Conversation
|
|
|
Local testing results:
|
|
Awesome! |
|
I was able to test the changes using the configuration here and I can confirm that it works very well with the GHE instance we use at work. |
There was a problem hiding this comment.
This working well for me after following the instructions from #1793 (comment):
- GHE: 2.22
- VSCode 1.53.2
- macOS 10.15.7
kabel
force-pushed
the
feature/ghe
branch
2 times, most recently
from
96ebd3b
to
f345be8
Compare
|
I was able to test the changes using #1793 and confirm it works very well with our GHE instance |
|
Everyone in our team is now using this since it was posted by @kabel. No issues since. We would love to see this merged as soon as possible. |
|
+1, would like to get this change reviewed and merged as soon as possible, the Github enterprise support is so important to us. |
|
Are there any updates on this? We are using the beta version provided by kabel, but need to reinstall it with each plugin update. All is ok with the beta version so far. |
Uses a new, proposed alternative authentication provider (switch) to handle authentication and API queries. Fixed microsoft#1793, microsoft#2282. Depends on microsoft/vscode#115940
Uses a field on the Remote to indicate which provider to use. The field compares the remote host to the GHE URI authority.
Requires node.js crypto (or browserify version) to do the md5 hash. Updates all interfaces and GraphQL queries to include the user email.
|
@kabel, any word from the vscode devs on getting this merged in? Thanks for building this feature! |
You're welcome. No word from upstream. Microsoft must keep them busy. |
|
I'm using the workaround right now. But as soon as this PR gets merged, I'll introduce this feature to everyone in my team. Hopefully, it will go in soon. |
Uses a new, proposed alternative authentication provider (switch) to handle authentication and API queries.
Fixed #1793, #2282.
Depends on microsoft/vscode#115940
Edit: Lastest rebase includes a different approach to the solution that allows both authentication providers to be used simultaneously. Which to query is determined by the remote matching the configured GHE URI.