Do not * activate the GHPRI extension #4051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
commented
Oct 14, 2022
| @@ -30,7 +30,6 @@ | |||
| "vscode.github-authentication" | |||
| ], | |||
| "activationEvents": [ | |||
| "*", | |||
There was a problem hiding this comment.
Realized that this PR as it stands isn't enough, because GHPRI sets a lot of context keys on activation which hide commands, and all of those context keys probably need to be revisited to ensure that functionality isn't improperly hidden. @alexr00 maybe we can chat about this further when you are in next week?
auto-merge was automatically disabled
October 21, 2022 16:04
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4046
It seems like the original intent of adding the * activation event was to improve the perceived speed of loading the PR diff when the current workspace is a PR, but this has the side effect of activating GHPRI even if the user doesn't have a PR checked out. Additionally, when testing this change with sideloaded GHPRI running out of sources in insiders.vscode.dev, it did not seem like the PR diff took much longer than usual to load.
This change seems safe to me and worthwhile to test out in insiders because if we can avoid unnecessary extension activation, we can reduce network and web worker extension host contention and hopefully improve overall performance of vscode.dev. Please let me know if I've missed some context!