Update branch for debugpy 1.5.1 with last changes in main #124

paulacamargo25 · 2023-10-31T21:44:12Z

Updating branch that uses dubugpy 1.5.1 with last changes

* Add port attribute provider * Add message * Enabled proposed api * Ignore all the ports * Fix format * fix pr comments * Add regex for terminal command * Add adapter to pattern

* Aff configuration * Read just my code from settings too * fix tests * fix lint

* Update package.json * Fix readme * update debug type name * Fix tests * Fix lint * Fix test * Update translations * revert extension id * Fix tests * fix lint * Update debug type name * Fix translations and lint * update debug type * fix lint

* Fix error in workspace * fix test and lint * Fix format

Bumps [mheap/github-action-required-labels](https://github.com/mheap/github-action-required-labels) from 3 to 5. - [Release notes](https://github.com/mheap/github-action-required-labels/releases) - [Commits](mheap/github-action-required-labels@v3...v5) --- updated-dependencies: - dependency-name: mheap/github-action-required-labels dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.11 to 5.62.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.62.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.3 to 5.2.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.1.3...v5.2.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update package.json * Fux lint

* Update nox file and pre release * update args * update value * see params * echo vars * fix args * fix args * Fix error obj to string * fix command line error * update args * update how access values * Add args * Send arguments * tried ith arguments * update value * remove args extra * update run * send as env * add to see other values * update env variables * use VSCETARGET * fix variable * Fix macOs error * Fix lint in nox file * Fix nox hash comparison * Fix default value * Remove unnecessary code * Update platform url and debugpy version * Fix dict key name * Remove vsix for all platforms * Fix pr comments * fix download function * fix hash code * Read from json pypypackage * add json file and session that creates it * Reformat nox file * resolve comments * fix lint error * update pipeline * fix build error * dont hardcode the hash

* Update readme * Update README.md Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> --------- Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>

brettcannon · 2023-11-23T18:04:54Z

.github/actions/build-vsix/action.yml

-    - name: Update pip, install pipx and install wheel
-      run: python -m pip install -U pip pipx wheel
+    - name: Update pip, install nox and install wheel
+      run: python -m pip install -U pip nox wheel


Why is wheel installed?

And GitHub Actions includes pipx by default, so you should be able to skip installing both Nox and pipx and use pipx run nox.

I removed pipx because I got an error using python 3.6

brettcannon · 2023-11-23T18:05:21Z

.github/actions/lint/action.yml

+    - name: Update pip, install nox and install wheel
+      run: python -m pip install -U pip nox wheel


See my comments on the other action.

.github/actions/lint/action.yml

brettcannon · 2023-11-23T18:08:36Z

noxfile.py

Is this any different from what's in main and that I already reviewed previously?

no, im just updating the branch that uses debugpy 1.5.1 with the latest changes in main.

package.json

brettcannon · 2023-11-23T18:15:06Z

I can't follow what the purpose of this PR is. I see changes around justMyCode defaults, renames related to the extension name, and changing the version of Debugpy (while tweaking some actions). I feel like there are 3 or more PRs all wrapped into one here.

brettcannon · 2024-01-09T23:20:30Z

With microsoft/vscode-python@3e75937 having landed, is this PR still relevant? If so, should it be prioritized?

karthiknadig · 2024-01-11T23:40:45Z

src/extension/debugger/configuration/providers/pidAttach.ts

@@ -20,7 +20,6 @@ export async function buildPidAttachConfiguration(
        type: DebuggerTypeName,
        request: 'attach',
        processId: '${command:pickProcess}',
-        justMyCode: true,


Was this removed because this is default?

paulacamargo25 and others added 18 commits October 31, 2023 14:46

update pre release (microsoft#71)

9991e78

Add port provider (microsoft#85)

117bc23

* Add port attribute provider * Add message * Enabled proposed api * Ignore all the ports * Fix format * fix pr comments * Add regex for terminal command * Add adapter to pattern

Add global configuration for justMyCode (microsoft#91)

d73a20e

* Aff configuration * Read just my code from settings too * fix tests * fix lint

Update extension name (microsoft#84)

77e97c9

* Update package.json * Fix readme * update debug type name * Fix tests * Fix lint * Fix test * Update translations * revert extension id * Fix tests * fix lint * Update debug type name * Fix translations and lint * update debug type * fix lint

use version 1.7 (microsoft#95)

ebab1f4

Remove default justMyCode (microsoft#100)

d2a7cb4

Fix error in workspace (microsoft#101)

422bec7

* Fix error in workspace * fix test and lint * Fix format

Update npm packages (microsoft#105)

df90d43

* update package.json * Fux lint

Update to node 18 (microsoft#106)

224bc8f

Fix GDPR comments (microsoft#113)

616f92e

Update readme (microsoft#111)

72efd8e

* Update readme * Update README.md Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> --------- Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>

Remove build folder from bundled vsix (microsoft#120)

3a55036

Update debugpy version

0203bc8

Update nox and pipelines

92d65af

paulacamargo25 force-pushed the update-3.6 branch from bfd6afa to 92d65af Compare October 31, 2023 21:48

paulacamargo25 added 2 commits November 1, 2023 14:23

update json file

08cae80

fix actions

8ddd17d

paulacamargo25 self-assigned this Nov 1, 2023

paulacamargo25 added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Nov 1, 2023

paulacamargo25 added 7 commits November 1, 2023 14:53

fix 3.6 error

1fe2017

fix error running with 3.6

1d7f338

fix lint

d1ed3cb

update python version

441b7ce

fix error in lint pipeline

cca7487

update pipelines

6bda57e

fix nox file

12eb6ed

fix tests

4fa43cb

paulacamargo25 marked this pull request as ready for review November 3, 2023 22:31

paulacamargo25 requested review from karthiknadig, eleanorjboyd and karrtikr November 3, 2023 22:31

fix pipeline error

eac8810

paulacamargo25 force-pushed the update-3.6 branch from e15e234 to eac8810 Compare November 22, 2023 19:31

fix lint

6d05e53

paulacamargo25 requested a review from brettcannon November 22, 2023 19:41

brettcannon suggested changes Nov 23, 2023

View reviewed changes

use python 3.6

bfb007b

brettcannon self-requested a review November 23, 2023 22:23

paulacamargo25 changed the title ~~Update 3.6~~ Update branch for debugpy 1.5.1 with last changes in main Nov 23, 2023

karthiknadig approved these changes Jan 12, 2024

View reviewed changes

paulacamargo25 enabled auto-merge (squash) January 15, 2024 20:46

brettcannon requested review from brettcannon and removed request for brettcannon January 15, 2024 20:48

brettcannon approved these changes Jan 15, 2024

View reviewed changes

paulacamargo25 merged commit aa64a98 into microsoft:release/python3.6/main Jan 15, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update branch for debugpy 1.5.1 with last changes in main #124

Update branch for debugpy 1.5.1 with last changes in main #124

paulacamargo25 commented Oct 31, 2023 •

edited

Loading

brettcannon Nov 23, 2023

paulacamargo25 Nov 23, 2023

brettcannon Nov 23, 2023

brettcannon Nov 23, 2023

paulacamargo25 Nov 23, 2023

brettcannon commented Nov 23, 2023

brettcannon commented Jan 9, 2024

karthiknadig Jan 11, 2024

paulacamargo25 Jan 12, 2024

		- name: Update pip, install nox and install wheel
		run: python -m pip install -U pip nox wheel

Update branch for debugpy 1.5.1 with last changes in main #124

Update branch for debugpy 1.5.1 with last changes in main #124

Conversation

paulacamargo25 commented Oct 31, 2023 • edited Loading

brettcannon Nov 23, 2023

Choose a reason for hiding this comment

paulacamargo25 Nov 23, 2023

Choose a reason for hiding this comment

brettcannon Nov 23, 2023

Choose a reason for hiding this comment

brettcannon Nov 23, 2023

Choose a reason for hiding this comment

paulacamargo25 Nov 23, 2023

Choose a reason for hiding this comment

brettcannon commented Nov 23, 2023

brettcannon commented Jan 9, 2024

karthiknadig Jan 11, 2024

Choose a reason for hiding this comment

paulacamargo25 Jan 12, 2024

Choose a reason for hiding this comment

paulacamargo25 commented Oct 31, 2023 •

edited

Loading