Add comments

microsoft · Mar 15, 2023 · 4330a98 · 4330a98
1 parent ba6ac95
commit 4330a98
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/client/interpreter/interpreterService.ts b/src/client/interpreter/interpreterService.ts
@@ -265,6 +265,7 @@ export class InterpreterService implements Disposable, IInterpreterService {
                 .then(async () => {
                     // Fetch interpreter details so the cache is updated to include the newly installed Python.
                     await this.getInterpreterDetails(pythonPath);
+                    // Fire an event as the executable for the environment has changed.
                     this.didChangeInterpreterEmitter.fire(workspaceFolder?.uri);
                     reportActiveInterpreterChanged({
                         path: pythonPath,

diff --git a/src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts b/src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts
@@ -150,12 +150,9 @@ export class PythonEnvInfoCache extends PythonEnvsWatcher<PythonEnvCollectionCha
         if (!found) {
             this.envs.push(env);
             this.fire({ new: env });
-        } else if (hasLatestInfo) {
-            const isValidated = this.validatedEnvs.has(env.id!);
-            if (!isValidated) {
-                // Update cache only if we have latest info and the env is not already validated.
-                this.updateEnv(found, env, true);
-            }
+        } else if (hasLatestInfo && !this.validatedEnvs.has(env.id!)) {
+            // Update cache if we have latest info and the env is not already validated.
+            this.updateEnv(found, env, true);
         }
         if (hasLatestInfo) {
             traceVerbose(`Flushing env to cache ${env.id}`);