Fixes

microsoft · Jul 3, 2019 · 7621eef · 7621eef
1 parent 818dc62
commit 7621eef
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/client/common/terminal/shellDetectors/baseShellDetector.ts b/src/client/common/terminal/shellDetectors/baseShellDetector.ts
@@ -54,8 +54,11 @@ export abstract class BaseShellDetector implements IShellDetector {
     public identifyShellFromShellPath(shellPath: string): TerminalShellType {
         const shell = Array.from(detectableShells.keys())
             .reduce((matchedShell, shellToDetect) => {
-                if (matchedShell === TerminalShellType.other && detectableShells.get(shellToDetect)!.test(shellPath)) {
-                    return shellToDetect;
+                if (matchedShell === TerminalShellType.other) {
+                    const pat = detectableShells.get(shellToDetect);
+                    if (pat && pat.test(shellPath)) {
+                        return shellToDetect;
+                    }
                 }
                 return matchedShell;
             }, TerminalShellType.other);