Skip to content

Commit

Permalink
Fix localization failure for pre-release (#22639)
Browse files Browse the repository at this point in the history
Fixes pre-release, dynamic strings are not supported by localization.
  • Loading branch information
Kartik Raj authored and karthiknadig committed Dec 13, 2023
1 parent d31b870 commit a712e12
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/client/logging/settingLogs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ async function notifyLegacySettings(): Promise<void> {
_isShown = true;
const response = await showWarningMessage(
l10n.t(
`You have deprecated linting or formatting settings for Python. Please see the [logs](command:${Commands.ViewOutput}) for more details.`,
'You have deprecated linting or formatting settings for Python. Please see the [logs](command:{0}) for more details.',
Commands.ViewOutput,
),
Common.learnMore,
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function parseDiagnostics(data: string): Diagnostic[] {
diagnostics = raw.map((item) => {
const d = new Diagnostic(
new Range(item.line, item.character, item.endLine, item.endCharacter),
l10n.t(`Package \`${item.package}\` is not installed in the selected environment.`),
l10n.t('Package `{0}` is not installed in the selected environment.', item.package),
item.severity,
);
d.code = { value: item.code, target: Uri.parse(`https://pypi.org/p/${item.package}`) };
Expand Down
3 changes: 2 additions & 1 deletion src/test/terminals/codeExecution/smartSend.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ suite('REPL - Smart Send', () => {
l10n.t(
`Python is unable to parse the code provided. Please
turn off Smart Send if you wish to always run line by line or explicitly select code
to force run. [logs](command:${Commands.ViewOutput}) for more details.`,
to force run. [logs](command:{0}) for more details.`,
Commands.ViewOutput,
),
'Switch to line-by-line',
),
Expand Down

0 comments on commit a712e12

Please sign in to comment.