Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blocklist and allowlist for debugger configuration for justMyCode #13719

Closed
jahan01 opened this issue Sep 1, 2020 · 6 comments
Closed
Assignees
Labels
area-debugging feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@jahan01
Copy link

jahan01 commented Sep 1, 2020

This is a feature request for breakpoint debugging - to add a new butting for "Step in into my code" in addition to current existing "Step in". This is same as PyCharms (or) any Jetbrains IDE.

This would help conditionally choosing in which part should I need to step into standard library.
so justMyCode is not helpful here - it either turns on or off the library debugging as whole.

If you don't like it, then I would like to have allowlist (and blocklist) options to specify libraries I want to step into (or not) when justMyCode is set to false. I think java debugger for vscode has something similar to this.

@jahan01 jahan01 added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Sep 1, 2020
@karthiknadig
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 1, 2020
@luabud luabud added needs proposal Need to make some design decisions and removed needs decision labels Oct 7, 2020
@luabud luabud self-assigned this Oct 7, 2020
@luabud luabud changed the title Feature request for adding new button for Debug: Step in into my code Implement blocklist and allowlist for debugger configuration Oct 7, 2020
@luabud luabud changed the title Implement blocklist and allowlist for debugger configuration Implement blocklist and allowlist for debugger configuration for justMyCode Oct 7, 2020
@luabud
Copy link
Member

luabud commented Oct 7, 2020

Thanks for the suggestion! We can't add an additional button for step in into my code as it would need to be solved by VS Code upstream, but we could implement your second suggestion. If you're interested, you can request your first option to VS Code directly: http://github.com/Microsoft/vscode

@luabud luabud closed this as completed Oct 7, 2020
@ghost ghost removed the needs proposal Need to make some design decisions label Oct 7, 2020
@jahan01
Copy link
Author

jahan01 commented Oct 8, 2020

but we could implement your second suggestion.

@luabud Since the issue is closed, so I take it as the second suggestion is reject as well ?

@karthiknadig
Copy link
Member

karthiknadig commented Oct 8, 2020

@jahan01 We have this 'allowlist' and 'blocklist' in the debugger. But we haven't yet exposed this. You can use the "rules" field to do this, but it is not final.

    {
      "name": "Python: Current File",
      "type": "python",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal",
      "rules": [
          {"path": "<glob pattern>", "include": true},  // Include or Exclude using a glob pattern or file name
          {"module": "module name", "include": true}, // Include or Exclude by module name
        ],
    },

@luabud luabud reopened this Oct 20, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Oct 20, 2020
@luabud
Copy link
Member

luabud commented Oct 20, 2020

Apologies, I had closed it by mistake 🤦‍♀️

@karrtikr
Copy link

Closing in favor of #13719 (comment).

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

4 participants