Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Pylance without reload prompt once it is detected #18509

Closed
kieferrm opened this issue Feb 11, 2022 · 5 comments
Closed

Restart Pylance without reload prompt once it is detected #18509

kieferrm opened this issue Feb 11, 2022 · 5 comments
Assignees
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority on-testplan Added to test plan verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

This shows the experience when creating a sample python dev container: https://cln.sh/KBwsUa (wait to the end of the recording...)

That I need to reload the window is not what I'd expect from a sample dev container (or in general). Since the Python extension activates on the existence of requirements.txt (see here) the language server change listener (see here is active.

It's unclear to why we need to reload the window if there is no open file at all. Also, we should make an effort to not require a reload. For example, the TS extension can recover from language server crashes/restarts without any reload.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 11, 2022
@kieferrm
Copy link
Member Author

There is an additional issue here: If the container build process runs a bit longer after the extensions load and the user has pushed the progress notification into the background, the container configuration process from the user's point of view seems to hang forever

image

...until the user clicks on the status bar item and sees the modal notification:

image

@karthiknadig
Copy link
Member

/cc @judej

@karthiknadig karthiknadig added area-editor-* User-facing catch-all triage bug Issue identified by VS Code Team member as probable bug and removed triage-needed Needs assignment to the proper sub-team labels Feb 14, 2022
@karrtikr karrtikr added investigating We are looking into the cause of the issue and removed triage labels Feb 14, 2022
@karrtikr karrtikr changed the title Reloading window when pylance is detected Restart Pylance without reload prompt once it is detected Feb 22, 2022
@karrtikr karrtikr removed their assignment Feb 22, 2022
@karrtikr karrtikr added important Issue identified as high-priority needs PR and removed investigating We are looking into the cause of the issue labels Feb 22, 2022
@karrtikr
Copy link

With the current way the dependency injection is set up, it's not very trivial but adding the ability to deactivate Jedi (default language server) should solve this.

The additional issue does not seem to be related to the extension cc/ @karthiknadig

@alexanderluiscampino
Copy link

Throwing my hat in the ring. I have adevcontainer post create command that install my reqs (poetry install) and it takes some time. By the time it is done, the pylance reload window disappeared and nothing gets done. It's a non-starter, since I won't be able to reload the window, and if I do, same happens, cycle repeats itself.

What is the purpose of this window reload upon installing pylance?

@rzhao271
Copy link

rzhao271 commented May 2, 2022

Looks like one of the endgame queries forgot to exclude on-testplan items for bugs. I'll label this issue as verified just to kick it off the query.

@rzhao271 rzhao271 added the verified Verification succeeded label May 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority on-testplan Added to test plan verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants