-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart Pylance without reload prompt once it is detected #18509
Comments
There is an additional issue here: If the container build process runs a bit longer after the extensions load and the user has pushed the progress notification into the background, the container configuration process from the user's point of view seems to hang forever ...until the user clicks on the status bar item and sees the modal notification: |
/cc @judej |
With the current way the dependency injection is set up, it's not very trivial but adding the ability to deactivate Jedi (default language server) should solve this. The additional issue does not seem to be related to the extension cc/ @karthiknadig |
Throwing my hat in the ring. I have adevcontainer post create command that install my reqs (poetry install) and it takes some time. By the time it is done, the pylance reload window disappeared and nothing gets done. It's a non-starter, since I won't be able to reload the window, and if I do, same happens, cycle repeats itself. What is the purpose of this window reload upon installing pylance? |
Looks like one of the endgame queries forgot to exclude on-testplan items for bugs. I'll label this issue as verified just to kick it off the query. |
This shows the experience when creating a sample python dev container: https://cln.sh/KBwsUa (wait to the end of the recording...)
That I need to reload the window is not what I'd expect from a sample dev container (or in general). Since the Python extension activates on the existence of
requirements.txt
(see here) the language server change listener (see here is active.It's unclear to why we need to reload the window if there is no open file at all. Also, we should make an effort to not require a reload. For example, the TS extension can recover from language server crashes/restarts without any reload.
The text was updated successfully, but these errors were encountered: