Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendCommand from server.ts #20662

Closed
eleanorjboyd opened this issue Feb 7, 2023 · 2 comments
Closed

Remove sendCommand from server.ts #20662

eleanorjboyd opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on verified Verification succeeded
Milestone

Comments

@eleanorjboyd
Copy link
Member

Currently there is a function called sendCommand in server.ts. This function was meant to be used in both pytest and unittest but it does not fit the requirements for pytest (additional parameters are needed). Therefore this code should be refactored to remove the sendCommand function and move logic into the test adapters per test.

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Feb 7, 2023
@eleanorjboyd eleanorjboyd self-assigned this Feb 7, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 7, 2023
@eleanorjboyd eleanorjboyd removed the triage-needed Needs assignment to the proper sub-team label Feb 23, 2023
@eleanorjboyd eleanorjboyd added the needs PR Ready to be worked on label Apr 28, 2023
@eleanorjboyd
Copy link
Member Author

looking at this and the server.ts has an object PythonTestServer which extends ITestServer. I am ok to change the type definition of ITestServer to align with my needs for the new testing infrastructure right? @karthiknadig

export interface ITestServer {
    readonly onDataReceived: Event<DataReceivedEvent>;
    sendCommand(options: TestCommandOptions): Promise<void>;
    serverReady(): Promise<void>;
    getPort(): number;
    createUUID(cwd: string): string;
}

@karthiknadig
Copy link
Member

We should change ITestServer to not include sendCommand.

@eleanorjboyd eleanorjboyd added this to the April 2024 milestone Apr 23, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants