Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendCommand from server.ts for testing #20997

Closed
eleanorjboyd opened this issue Apr 5, 2023 · 1 comment
Closed

Remove sendCommand from server.ts for testing #20997

eleanorjboyd opened this issue Apr 5, 2023 · 1 comment
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@eleanorjboyd
Copy link
Member

Currently unittest discovery / execution is run by calling the function sendCommand in server.ts. Since pytest does not use the sendCommand function due to its different design, this command should be removed the the server.ts and instead placed in the unittest specific utils.

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Apr 5, 2023
@eleanorjboyd eleanorjboyd self-assigned this Apr 5, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 5, 2023
@karthiknadig karthiknadig added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Apr 5, 2023
@eleanorjboyd
Copy link
Member Author

duplicate of #20662

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
@eleanorjboyd eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

2 participants