Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL Rewrite #21707

Open
22 of 24 tasks
anthonykim1 opened this issue Jul 28, 2023 · 4 comments
Open
22 of 24 tasks

REPL Rewrite #21707

anthonykim1 opened this issue Jul 28, 2023 · 4 comments
Assignees
Labels
area-repl feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@anthonykim1
Copy link

anthonykim1 commented Jul 28, 2023

Below lists plans for REPL in VS Code Python as of (May 31st, 2024).
More subset of steps are subject to being added as I move forward incrementally.

Milestone 1:

  • Investigate the state of REPL support in the extension Investigate the state of REPL support in the extension #21590
  • Become familiar with REPL code
  • Implement Run Selection/Line in xxx be more smart Run Selection/Line in xxx be more smart? #18105 (Has to be merged after removing support for 3.7) and Implement smart shift+enter using AST #21778
  • Implement Go to next line only when non-selection/non-highlighted case Dynamic Smart Cursor Movement #21838 (Has to be merged after removing support for 3.7 along with the previous item)
  • Create, fix tests that were testing selection previously.
  • Set up an experiment for smart shift+enter and Go to next block line (dynamic cursor movement) in code base.
  • Deprecate 3.7 and merge the smart send (smart shift+enter, go to next block line) after.
  • Create tests for both TypeScript and Python side for smart selection, dynamic cursor movement
  • Enable experiments for all tests in the repo, specifically beneficial for smoke test involving new features.
  • Warning message, and setting to show when user is trying to smart send with invalid code in the currently opened Python file.

Milestone 2:

Milestone 3:

@anthonykim1 anthonykim1 self-assigned this Jul 28, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 28, 2023
@anthonykim1 anthonykim1 added this to the August 2023 milestone Jul 28, 2023
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Jul 28, 2023
@brettcannon brettcannon added feature-request Request for new features or functionality needs PR Ready to be worked on area-repl labels Aug 31, 2023
@brettcannon brettcannon modified the milestones: November 2023, December 2023 Nov 27, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@rchiodo
Copy link

rchiodo commented Jun 3, 2024

@anthonykim1 @luabud I was wondering if the new REPL would be able to support completions from a language server? Does VS code give you the ability to put up a completion list? (Maybe similar to how history works?, you tab and then it tabs through completions)

@anthonykim1
Copy link
Author

Hello @rchiodo I'm not entirely sure what you mean, but are you talking about Intellisense? In terms of command history, I believe you can use up and down arrow to navigate through previous commands in the new notebook style REPL.
Screenshot 2024-06-04 at 10 48 03 AM

@rchiodo
Copy link

rchiodo commented Jun 4, 2024

That screenshot is exactly what I was talking about. Completions for the code module. It looks like the REPL is already doing what I asked for then :)

@anthonykim1
Copy link
Author

anthonykim1 commented Jun 4, 2024

Great! Try adding

"interactiveWindow.executeWithShiftEnter": false,
"python.REPL.sendToNativeREPL": true,

in your settings.json to give the new REPL a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants