Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code on wrong command in shell integration history #22942

Closed
andreamah opened this issue Feb 20, 2024 · 2 comments
Closed

Exit code on wrong command in shell integration history #22942

andreamah opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
area-repl info-needed Issue requires more information from poster

Comments

@andreamah
Copy link

Testing #22926

I ran shell integration with the following lines:

print(sys.argv[0])
print(sys.argv[1])
print('uwu')

In the REPL, the second line fails, but the terminal history shows line 1 as having an exitCode of 1.

image image
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 20, 2024
@anthonykim1
Copy link

This is weird since the decoration seems to be correct, but the exit code is only showing once next to 'print(sys.argv[0]'? I think it may be the injection sequence, I'll take a look at this.

@anthonykim1 anthonykim1 added area-repl and removed triage-needed Needs assignment to the proper sub-team labels Feb 23, 2024
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Feb 23, 2024
@anthonykim1
Copy link

this is now fixed

@anthonykim1 anthonykim1 mentioned this issue Mar 18, 2024
24 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-repl info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants