-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIs required by Tensorboard ext (as well as Jupyter ext) #22174
Comments
The sort term solution looks fine.
Is the current |
Nope, that only returns env varialbes from the |
@karrtikr I thought you updated this to include the |
Nope, we do not know for sure how activation will look until experiment is finalized, hence we haven't exposed the APIs yet. |
I too thought it was done, and I feel the method Unless of course one reads the comments |
Please can you point me to that code, |
I think I mentioned before in slack that exposing such an API is blocked on #20950 where we're actively working with VS Code to finalize how activation will look like, which determines the shape of the API. If we find out using activated environment variables is sufficient, we can expose |
I think having two APIs for getting environment variables can get confusing. We can discuss this offline. |
There are a few requirements in Tensorboard (& Jupyter ext), and I will not create separate issues for each of the APIs as the solution/API exposed could end up being different.
Requirements
Proposed solutions
Note:
getActivatedEnvVars
Related issues
@karrtikr @karthiknadig /cc
The text was updated successfully, but these errors were encountered: