Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to enable linters/formatters by directory without deactivating the extension #22607

Open
noirbizarre opened this issue Dec 7, 2023 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@noirbizarre
Copy link

noirbizarre commented Dec 7, 2023

Hi 👋🏼

Extracting linters and formatters into their own extensions was a good move in my opinion, but we lost some important features because before it was possible to:

  • to toggle them by directory in multiple root workspace, not possible anymore if the only way is to disable the extension
  • to mix them in a multiroot workspace (eg. have flake8 as project-a linter and pylint as project-b linter), not possible anymore, they are either active on the entire workspace or totally disabled (so you need to chose only one, deactivate the other or else you only have false positive)
  • to toggle them without VSCode restart (deactivating a linter extension requires a restart)
  • to toggle them from configuration file (which are versionnable and shareable), not possible anymore, extensions are exclusively managed by VSCode internals

So, given they use a common base template, is it possible to restore those behaviors by:

  • adding <extension namespace>.enabled boolean setting
  • ensure it is working by directory and not by workspace (this is very important for multiroots workspaces)
  • bonus: make this setting apply without a restart
@noirbizarre noirbizarre added the feature-request Request for new features or functionality label Dec 7, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 7, 2023
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Dec 12, 2023
@karthiknadig
Copy link
Member

@noirbizarre we have a ".ignorePatterns" that can be used temporarily as a workaround to skip any directory or workspaces. You can use ${workspaceFolder:<name>} as a shortcut to skip a particular workspace.

We do plan on adding a boolean setting to the extensions.

@karthiknadig karthiknadig added the needs PR Ready to be worked on label Dec 12, 2023
@noirbizarre
Copy link
Author

Thanks for the quick response!
That's very good news! 🎉

Is there an issue I can track on the topic or is this still an internal backlog/roadmap currently?

Thanks for the workaround, I'll try it until this is implemented 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants