-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contribution points to extension API to add external support for Rye, pixi etc #22797
Comments
We have the same problem with pixi. Would it help if the It at least sounds like something I would wanna use for pixi as well. |
We are starting to discuss the idea of a workflow API that would allow extensions to provide contribution points that we delegate to when available. That way we can provide a default experience that can be overridden as appropriate by other workflow tools (it would also mean we would pull out our own support for anything that isn't pip + venv into separate extensions). So this is an issue we are thinking about how to solve. @baszalmstra FYI I've already talked to Wolf about this idea. |
Closes #22978 This adds a locator implementation that properly detects [Pixi](https://pixi.sh/) environments. Pixi environments are essentially conda environments but placed in a specific directory inside the project/workspace. This PR properly detects these and does not do much else. This would unblock a lot of pixi users. I would prefer to use a custom pixi plugin but since the [contribution endpoints are not available yet](#22797) I think this is the next best thing. Before I put more effort into tests I just want to verify that this approach is valid. Let me know what you think! :) --------- Co-authored-by: Tim de Jager <tim@prefix.dev>
Closes microsoft#22978 This adds a locator implementation that properly detects [Pixi](https://pixi.sh/) environments. Pixi environments are essentially conda environments but placed in a specific directory inside the project/workspace. This PR properly detects these and does not do much else. This would unblock a lot of pixi users. I would prefer to use a custom pixi plugin but since the [contribution endpoints are not available yet](microsoft#22797) I think this is the next best thing. Before I put more effort into tests I just want to verify that this approach is valid. Let me know what you think! :) --------- Co-authored-by: Tim de Jager <tim@prefix.dev>
Closes microsoft#22978 This adds a locator implementation that properly detects [Pixi](https://pixi.sh/) environments. Pixi environments are essentially conda environments but placed in a specific directory inside the project/workspace. This PR properly detects these and does not do much else. This would unblock a lot of pixi users. I would prefer to use a custom pixi plugin but since the [contribution endpoints are not available yet](microsoft#22797) I think this is the next best thing. Before I put more effort into tests I just want to verify that this approach is valid. Let me know what you think! :) --------- Co-authored-by: Tim de Jager <tim@prefix.dev>
This is not an issue I really wanted to open, because I was hoping I can avoid putting yet another thing into the ecosystem that requires custom handling. Unfortunately vscode currently installs tools itself (eg:
black
etc.) directly in this extension. Rye does not placepip
in the virtualenv and requires you to install tools via other means.Thus for Rye to work well, unfortunately it looks like this extension would have to be expanded.
rye
based module installed which invokesrye add --dev package-name
followed byrye sync
rye tools install package-name
(globally instead?)rye lint
andrye fmt
which directly pass through to ruff which it bundlesI'm not at all happy that this might mean adding another tool to the list of things that this extension needs to maintain, so I'm open to alternatives. One thought that I had as to add hidden
pip
support to rye but unfortunately this breaks a lot of stuff. While I can make a fakepip
command available that just internally callsrye add
, the module check also requires that the pip module in installed which I don't want to do. It would make it impossible for a user to actually installpip
if they need it.I'm also not sure how much interest there is at this point for Rye support in vscode, so maybe that issue can also act as a way to track interest.
Relates to astral-sh/rye#556
The text was updated successfully, but these errors were encountered: