Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype communication between custom Python REPL and Node #23174

Closed
anthonykim1 opened this issue Apr 3, 2024 · 2 comments · Fixed by #23235
Closed

Prototype communication between custom Python REPL and Node #23174

anthonykim1 opened this issue Apr 3, 2024 · 2 comments · Fixed by #23235
Assignees
@anthonykim1
Labels
area-repl feature-request Request for new features or functionality verified Verification succeeded
Milestone
May 2024

Comments

@anthonykim1
Copy link

In order for custom REPL and Python extension's notebook controller can communicate, we need to build way of communication leveraging VS Code's https://www.npmjs.com/package/vscode-jsonrpc and jsonrpc-async, jsonrpc-websockets.

Using https://www.npmjs.com/package/@vscode/python-extension, we should first create separate prototype extension to make sure communication happens smoothly between TypeScript side and Python side that has the custom REPL before embeding code into VS Code Python repo's notebook controller: #23100
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-repl labels Apr 3, 2024
@anthonykim1 anthonykim1 added this to the April 2024 milestone Apr 3, 2024
@anthonykim1 anthonykim1 self-assigned this Apr 3, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 3, 2024
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Apr 3, 2024
@kieferrm kieferrm mentioned this issue Apr 7, 2024
Closed
18 tasks
@anthonykim1 anthonykim1 mentioned this issue Apr 15, 2024
Merged
@karthiknadig
Copy link
Member

Closing this as this is done, it is not testable yet.

@karthiknadig karthiknadig removed the feature-request Request for new features or functionality label Apr 17, 2024
@karthiknadig karthiknadig modified the milestones: April 2024, May 2024 Apr 17, 2024
@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Apr 17, 2024
anthonykim1 added a commit that referenced this issue May 16, 2024
@anthonykim1
Add Interactive REPL Experiment (#23235)
6997f7b 
Allow users to use Interactive Window UI with Python custom REPL
controller instead of iPykernel.
Closes #23175
Closes #23174 
Closes #23029
Majority of: #23332 

Context menu under Python for running Python REPL code using IW UI
should only appear when user's ```pythonRunREPL``` experiment is
enabled.
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this issue May 16, 2024
@anthonykim1
Add Interactive REPL Experiment (microsoft#23235)
225da4b 
Allow users to use Interactive Window UI with Python custom REPL
controller instead of iPykernel.
Closes microsoft#23175
Closes microsoft#23174 
Closes microsoft#23029
Majority of: microsoft#23332 

Context menu under Python for running Python REPL code using IW UI
should only appear when user's ```pythonRunREPL``` experiment is
enabled.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
@benibenj benibenj added the verification-needed Verification of issue is requested label May 28, 2024
@ulugbekna ulugbekna added the verification-steps-needed Steps to verify are needed for verification label May 28, 2024
@anthonykim1
Copy link
Author

Marking this as verified so they do not appear in the endgame queries. This will be tested via #23484

@anthonykim1 anthonykim1 added verified Verification succeeded and removed verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification labels May 28, 2024
DonJayamanne pushed a commit that referenced this issue Jun 24, 2024
@anthonykim1 @DonJayamanne
Add Interactive REPL Experiment (#23235)
a8a0e59 
Allow users to use Interactive Window UI with Python custom REPL
controller instead of iPykernel.
Closes #23175
Closes #23174 
Closes #23029
Majority of: #23332 

Context menu under Python for running Python REPL code using IW UI
should only appear when user's ```pythonRunREPL``` experiment is
enabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-repl feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Add Interactive REPL Experiment anthonykim1/vscode-python
4 participants
@karthiknadig @ulugbekna @benibenj @anthonykim1