Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook content is sent to python repl to execute #23555

Closed
amunger opened this issue Jun 4, 2024 · 1 comment · Fixed by #23572
Closed

notebook content is sent to python repl to execute #23555

amunger opened this issue Jun 4, 2024 · 1 comment · Fixed by #23572
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug

Comments

@amunger
Copy link

amunger commented Jun 4, 2024

Type: Bug

I was repro'ing this without needing step 2 in OSS, it might depend on which order extensions are installed

  1. install jupyter and python extensions and set "python.REPL.sendToNativeREPL": true
  2. remove the keybinding for shift+enter to execute and select below from the jupyter keymap extension
  3. open a notebook with python cells
  4. type print(1) and press shift+enter in the cell
    🐛 code is sent to the python repl

Extension version: 2024.7.11511013
VS Code version: Code - Insiders 1.90.0-insider (89de5a8d4d6205e5b11647eb6a74844ca23d2573, 2024-06-04T01:34:32.847Z)
OS version: Windows_NT x64 10.0.22631
Modes:

  • Python version (& distribution if applicable, e.g. Anaconda): 3.11.9
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): MicrosoftStore
  • Value of the python.languageServer setting: Default
User Settings


languageServer: "Pylance"

Installed Extensions
Extension Name Extension Id Version
Dev Containers ms-vscode-remote.remote-containers 0.368.0
EditorConfig for VS Code EditorConfig.EditorConfig 0.16.4
ESLint dbaeumer.vscode-eslint 3.0.7
Extension Test Runner ms-vscode.extension-test-runner 0.0.9
GitHub Copilot GitHub.copilot 1.198.0
GitHub Copilot Chat GitHub.copilot-chat 0.16.2024060401
GitHub Issue Notebooks ms-vscode.vscode-github-issue-notebooks 0.0.130
GitHub Pull Requests GitHub.vscode-pull-request-github 0.89.2024053108
JavaScript Debugger ms-vscode.js-debug 1.90.0
JavaScript Debugger Companion Extension ms-vscode.js-debug-companion 1.1.2
Jupyter ms-toolsai.jupyter 2024.5.2024052901
Jupyter Cell Tags ms-toolsai.vscode-jupyter-cell-tags 0.1.9
Jupyter Keymap ms-toolsai.jupyter-keymap 1.1.2
Jupyter Notebook Renderers ms-toolsai.jupyter-renderers 1.0.17
Jupyter Slide Show ms-toolsai.vscode-jupyter-slideshow 0.1.6
PR Pinger jrieken.vscode-pr-pinger 0.0.6
Pylance ms-python.vscode-pylance 2024.5.103
Python ms-python.python 2024.7.11511013
Python Debugger ms-python.debugpy 2024.7.11371017
Table Visualizer for JavaScript Profiles ms-vscode.vscode-js-profile-table 1.0.9
VS Code Selfhost Test Provider ms-vscode.vscode-selfhost-test-provider 0.4.0
System Info
Item Value
CPUs Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz (16 x 2793)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
Load (avg) undefined
Memory (System) 63.95GB (38.62GB free)
Process Argv --crash-reporter-id ef2310ee-a8c0-40bb-a2e3-d2dd59800224
Screen Reader no
VM 0%
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
vsaa593:30376534
py29gd2263:31024238
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pythonmypyd1:30859725
pythoncet0:30859736
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
jchc7451:31067543
showvideot:31016890
chatpanelt:31014475
jg8ic977:31013176
a69g1124:31018687
dvdeprecation:31040973
pythonprt:31036556
dwnewjupyter:31046869
nb_pri_only:31057983
fa862199:31048878

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 4, 2024
@anthonykim1
Copy link

Discussed adding !notebookEditorFocused for python.execInREPL when clause or any other when clause that can distinguish Python file that is not Jupyter notebook. - adding as part of point release.
Users affected: Users who are in sendToNative REPL experiment who does not have Jupyter extension and is trying to use other types of notebook.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Jun 4, 2024
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Jun 4, 2024
karthiknadig pushed a commit that referenced this issue Jun 13, 2024
fix #23555

Co-authored-by: Aaron Munger <aaron.munger@gmail.com>
DonJayamanne pushed a commit to DonJayamanne/pythonVSCode that referenced this issue Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-repl bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants