Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch formatting on type to the language server #2690

Closed
MikhailArkhipov opened this issue Sep 26, 2018 · 3 comments
Closed

Switch formatting on type to the language server #2690

MikhailArkhipov opened this issue Sep 26, 2018 · 3 comments
Assignees
@jakebailey
Labels
area-formatting feature-request Request for new features or functionality
Milestone
2018, week 40 - O...

Comments

@MikhailArkhipov
Copy link

Per microsoft/python-language-server#5

This should close outstanding issues in #1799 as well as

#2323
#1784
#1792

@brettcannon - can you please add @jakebailey to contributors so he can make the change. Thanks.
@MikhailArkhipov MikhailArkhipov added feature-request Request for new features or functionality area-formatting labels Sep 26, 2018
@brettcannon
Copy link
Member

@MikhailArkhipov @jakebailey Done!

@jakebailey jakebailey self-assigned this Sep 27, 2018
@jakebailey jakebailey mentioned this issue Sep 27, 2018
Closed
@jakebailey
Copy link
Member

jakebailey commented Sep 27, 2018 •
edited
Loading

For now, this is blocked by #2714, since that code is what will need to be moved into activation/jedi.ts. (That is unless I make two changes in one PR, which the PR template frowns upon.)

@jakebailey jakebailey mentioned this issue Oct 1, 2018
Merged
6 tasks
DonJayamanne pushed a commit that referenced this issue Oct 9, 2018
@jakebailey @DonJayamanne
Enable on-type formatting from language server (#2737)
eecb4dd 
For #2690.

Similar to #2612. Note that `:`-based formatting isn't implemented in language server yet (microsoft/python-language-server#165), but it hasn't been enabled in the extension for anyone for a while now either (fixed in #2714/#2724).

Since line formatting is relatively new in language server, this likely shouldn't make it out into a release until the language server downloaded by default is new enough to include that functionality. I haven't been monitoring that side of things, so feel free to hold off on merging this until the right time.
@brettcannon
Copy link
Member

I can validate this works in at least 0.1.44 of the language server.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakebailey jakebailey

Labels
area-formatting feature-request Request for new features or functionality
Projects
None yet
Milestone
2018, week 40 - October Sprint 1
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @jakebailey @MikhailArkhipov