Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set "python.linting.pylintEnabled": false in package.json. #3007

Closed
d3r3kk opened this issue Oct 24, 2018 · 5 comments
Closed

Set "python.linting.pylintEnabled": false in package.json. #3007

d3r3kk opened this issue Oct 24, 2018 · 5 comments
Assignees
@rchiodo @kimadeline
Labels
area-linting feature-request Request for new features or functionality important Issue identified as high-priority verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2021

Comments

@d3r3kk
Copy link

d3r3kk commented Oct 24, 2018

Related to #974, PR #2913

Once the Python Language Server is enabled for our users by default, update package.json to change the default setting for python.linting.pylintEnabled to false.

@DonJayamanne @brettcannon @qubitron
@d3r3kk d3r3kk added feature-request Request for new features or functionality area-linting needs PR labels Oct 24, 2018
@d3r3kk
Copy link
Author

d3r3kk commented Oct 24, 2018

Tracked against the current milestone, but this might get pushed out.
@brettcannon please correct this if necessary!

@DonJayamanne
Copy link

Hows this different from #974?
Wouldn't your change above, resolve #974?

@brettcannon
Copy link
Member

It's different because #974 makes this a conditional thing that only kicks in when you flip on the language server. Once the language server is the default we can actually flip the default here so that when we stop special-casing Pylint the default is what we want it to be.

@d3r3kk d3r3kk mentioned this issue Nov 1, 2018
Closed
@d3r3kk d3r3kk mentioned this issue Dec 10, 2018
Closed
@luabud luabud added the important Issue identified as high-priority label Feb 19, 2021
@brettcannon brettcannon added this to the September 2021 milestone Sep 1, 2021
@kimadeline kimadeline self-assigned this Sep 15, 2021
kimadeline added a commit to kimadeline/vscode-python that referenced this issue Sep 15, 2021
@kimadeline
Set pylintEnabled default to false, closes microsoft#3007
1b5209a
@kimadeline kimadeline mentioned this issue Sep 15, 2021
Merged
@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Sep 27, 2021
@kimadeline
Copy link

kimadeline commented Sep 27, 2021 •
edited
Loading

Verification steps

  1. Enable the Python extension
  2. Verify that the default value for the python.linting.pylintEnabled setting is false

@rchiodo rchiodo self-assigned this Sep 28, 2021
@rchiodo rchiodo added the verified Verification succeeded label Sep 28, 2021
@rchiodo
Copy link

rchiodo commented Sep 28, 2021

/verified

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

@kimadeline kimadeline

Labels
area-linting feature-request Request for new features or functionality important Issue identified as high-priority verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
7 participants
@brettcannon @DonJayamanne @karthiknadig @d3r3kk @rchiodo @luabud @kimadeline