-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for black's daemon, blackd #3336
Comments
If anyone has a setup for this in the meantime, please share it here. |
Another option instead of adding specific support for blackd might be using https://github.com/rupert/pyls-black. |
We now have a black formatter extension, https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter please give it a try. This extension runs black over LSP, should be more performant than running black each time. |
@karthiknadig this is a revelation! having |
Great!
That's actually not going to happen. The plan is to remove the Black support from the core extension and keep the support in the separate extension. This will make the core extension smaller as well as let us update the Black extension independently of the core extension (and this is why we are comfortable shipping a copy of Black in the extension itself). |
Good to know @brettcannon Worthwhile updating/deleting this line? https://github.com/microsoft/vscode-black-formatter/blob/c962ac3aa71eec9ca1471075b3a4ff832c6f6afb/README.md?plain=1#L10 If that's the case - hopefully in the end the setting can just return to |
@magnetikonline But this line is exactly saying what @brettcannon wrote here. |
Ah so it does. Reading it the wrong way! 👍 |
Closing this issue in context of the recent comments #3336 (comment). cc/ @karthiknadig |
Black has a new feature called blackd:
https://black.readthedocs.io/en/stable/blackd.html
Supporting it out of the box would be useful and probably speed up formatting!
The text was updated successfully, but these errors were encountered: