Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter throws errors #447

Closed
DonJayamanne opened this issue Dec 17, 2017 · 1 comment · Fixed by #536
Closed

Linter throws errors #447

DonJayamanne opened this issue Dec 17, 2017 · 1 comment · Fixed by #536
Assignees
@MikhailArkhipov
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone
January 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Dec 17, 2017 •
edited
Loading

Originally reported by @MFairley in #444 (split out the bug into a separate issue).

Environment data

VS Code version: 1.19.0 (1.19.0)
Python Extension version: 0.9.0
Python Version: Anaconda 2.7.14
OS and version: mac OS 10.13.2

Actual behavior

Updates to Pylint messages are very slow even after saving, it takes several seconds for messages to change. For example, if a variable is undefined and then defined, the linter will take several seconds to update it's undefined variable message.

Steps to reproduce:

  • Have a Pylint message
  • Fix the error associated with the message
  • Save to lint
  • Message will take some time to disappear

Logs

Output from Console window (Help->Developer Tools menu)

TypeError: Cannot read property 'TokenType' of undefined
	at CompletionSource.isPositionInsideStringOrComment (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:115:44)
	at CompletionSource.<anonymous> (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:78:22)
	at Generator.next (<anonymous>)
	at __awaiter (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:9:71)
	at Promise (<anonymous>)
	at __awaiter (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:5:12)
	at CompletionSource.getCompletionResult (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:68:16)
	at CompletionSource.<anonymous> (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:40:39)
	at Generator.next (<anonymous>)
	at __awaiter (/Users/mfairley/.vscode/extensions/ms-python.python-0.9.0/out/client/providers/completionSource.js:9:71)

(node:13752) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:249
11:18:45.522 console.ts:123 [Extension Host] (node:13752) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ console.ts:123
@DonJayamanne DonJayamanne added awaiting 2-PR area-linting bug Issue identified by VS Code Team member as probable bug labels Dec 17, 2017
@DonJayamanne DonJayamanne mentioned this issue Dec 17, 2017
Closed
@MikhailArkhipov MikhailArkhipov self-assigned this Jan 4, 2018
@MikhailArkhipov
Copy link

Exception is probably unrelated to the speed issue

@MikhailArkhipov MikhailArkhipov mentioned this issue Jan 5, 2018
Merged
MikhailArkhipov pushed a commit that referenced this issue Jan 9, 2018
Fix exception reported in #447 (#536)
7f2c239 
* Basic tokenizer

* Fixed property names

* Tests, round I

* Tests, round II

* tokenizer test

* Remove temorary change

* Fix merge issue

* Merge conflict

* Merge conflict

* Completion test

* Fix last line

* Fix javascript math

* Make test await for results

* Add license headers

* Rename definitions to types

* License headers

* Fix typo in completion details (typo)

* Fix hover test

* Russian translations

* Update to better translation

* Fix typo

*  #70 How to get all parameter info when filling in a function param list

* Fix #70 How to get all parameter info when filling in a function param list

* Clean up

* Clean imports

* CR feedback

* Trim whitespace for test stability

* More tests

* Better handle no-parameters documentation

* Better handle ellipsis and Python3

* Basic services

* Install check

* Output installer messages

* Warn default Mac OS interpreter

* Remove test change

* Add tests

* PR feedback

* CR feedback

* Mock process instead

* Fix Brew detection

* Update test

* Elevated module install

* Fix path check

* Add check suppression option & suppress vor VE by default

* Fix most linter tests

* Merge conflict

* Per-user install

* Handle VE/Conda

* Fix tests

* Remove double service

* #447 Linter throws errors

* Better test names
@brettcannon brettcannon added this to the January 2018 milestone Jan 9, 2018
@DonJayamanne DonJayamanne mentioned this issue Jan 29, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Fix exception reported in #447
3 participants
@brettcannon @DonJayamanne @MikhailArkhipov