Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage #464

Closed
DonJayamanne opened this issue Dec 20, 2017 · 0 comments · Fixed by #475
Closed

Add code coverage #464

DonJayamanne opened this issue Dec 20, 2017 · 0 comments · Fixed by #475
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
January 2018

Comments

@DonJayamanne
Copy link

Unfortunately the way the tests are run, adding code coverage may not be easy.
Some research is necessary in this space (look for work arounds, or run a second set of tests with a modified version of the vscode test launcher scripts).
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 20, 2017
@DonJayamanne DonJayamanne mentioned this issue Dec 22, 2017
Merged
DonJayamanne added a commit that referenced this issue Jan 3, 2018
@DonJayamanne
Yarn and code coverage (#475)
9853956 
* Fixes #421 (move from npm to yarn)
* Fixes #464 (code coverage of the extension code) 
* Fixes to some unit tests that were failing just on Windows
@DonJayamanne DonJayamanne added this to the January 2018 milestone Jan 4, 2018
@brettcannon brettcannon mentioned this issue Jan 29, 2018
Closed
38 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Yarn and code coverage DonJayamanne/pythonVSCode
3 participants
@brettcannon @ericsnowcurrently @DonJayamanne