"Rename Symbol" often fails to rename when using Rope

[NickGrattan]

Environment data

VS Code version: 1.18.0
Python Extension version: 0.8.0
Python Version: 3.5.3 Anaconda 4.0.0
OS and version: Widows 10 Professional

Actual behavior

"Symbol Rename" for a Python symbol fails to rename in about 50% of cases. The symbol remains as its old name and is not renamed

Expected behavior

Rename to rename symbols everytime.

Steps to reproduce:

• Select symbol (e.g. "node"), choose "Rename Symbol" from context menu
• Enter new symbol name (e.g. "node2")
  
• Press Enter
  Symbol may not be renamed

Logs

Output from Python output panel
No output

Output from ```Console window``` (Help->Developer Tools menu)
No output

[brettcannon]

I can verify this is an issue. Using the following code:

def fxn():
    B = 42
    Y = B + 13
    return B + Y

I just simply tried renaming B multiple times in a row and after about 3 times it started to work about every other time. Not sure if this is our doing or Rope's doing.

[puzzler10]

Actually, when I tried doing rename on that code (changing B to O) it went from

def fxn():
    B = 42
    Y = B + 13
    return B + Y

to

def fxn():
    Y = O + 13
    return O + Y

deleting a line completely.

[brettcannon]

@puzzler10 can you open a new issue?

[fredrikaverpil]

I'm on the latest vscode (to date) and I find renaming symbols is a "hit or miss" feature. Feels like there's a 50% chance it works with Python code.

[brettcannon]

@fredrikaverpil the trickiness with this is knowing whether this is our fault or rope not working properly.

[fredrikaverpil]

@brettcannon I understand. Hm. When it misses the next time, is there any way I troubleshoot it and investigate whether it is rope's fault?

EDIT: And by the way, thanks for an absolutely fantastic product. I live and breathe Python in vscode at least 8hrs a day 😉