Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indent/dedent for "return" syntax. #6564

Closed
kimadeline opened this issue Jul 12, 2019 · 2 comments
Closed

Fix indent/dedent for "return" syntax. #6564

kimadeline opened this issue Jul 12, 2019 · 2 comments
Labels
area-formatting feature-request Request for new features or functionality
Milestone
2019 - August Spr...

Comments

@kimadeline
Copy link

kimadeline commented Jul 12, 2019 •
edited by ericsnowcurrently
Loading

While working on #6333, the dedent regex was kept simple for the return keyword (see #6497 (comment)), but didn't cover the case for return followed by a dangling [, ( or { before the cursor.

This issue also covers restoring the dedent removed for #6813 (added for #6333).

Current (pre-#6813) behaviour (merged in #6497):

current

Expected/desired behaviour:

expected
@kimadeline kimadeline added feature-request Request for new features or functionality area-formatting triage-needed Needs assignment to the proper sub-team needs PR labels Jul 12, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 12, 2019
@DonJayamanne DonJayamanne changed the title Improve indentation rule for return statement followed by a dangling [, { or ( Spike - Improve indentation rule for return statement followed by a dangling [, { or ( Jul 17, 2019
@DonJayamanne DonJayamanne added this to the 2019 - July Sprint 14 milestone Jul 17, 2019
@DonJayamanne DonJayamanne changed the title Spike - Improve indentation rule for return statement followed by a dangling [, { or ( Remove return statement support Jul 29, 2019
@ericsnowcurrently ericsnowcurrently self-assigned this Jul 30, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Aug 1, 2019
Closed
@ericsnowcurrently ericsnowcurrently changed the title Remove return statement support Fix indent/dedent for "return" syntax. Aug 1, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Aug 1, 2019
@ericsnowcurrently ericsnowcurrently removed this from the 2019 - July Sprint 15 milestone Aug 1, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Aug 12, 2019
Merged
6 tasks
ericsnowcurrently added a commit that referenced this issue Aug 13, 2019
@ericsnowcurrently
Drop dedent-on-enter for "return" statements. (#6939)
11dd074 
(for #6813)

We'll work on adding support back in #6564.
@DonJayamanne
Copy link

DonJayamanne commented Aug 14, 2019 •
edited
Loading

Prescribed Solution:

@DonJayamanne DonJayamanne added this to the 2019 - August Sprint 16 milestone Aug 14, 2019
@luabud luabud mentioned this issue Aug 20, 2019
Closed
@brettcannon
Copy link
Member

The original PR was reverted, so there's nothing to fix here as long as we don't bring this feature back.

@ghost ghost removed the needs PR label Aug 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-formatting feature-request Request for new features or functionality
Projects
None yet
Milestone
2019 - August Sprint 16
Development

No branches or pull requests
4 participants
@brettcannon @ericsnowcurrently @DonJayamanne @kimadeline