Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to flip "inheritEnv" setting to false to fix conda activation issue #7607

Closed
luabud opened this issue Sep 25, 2019 · 7 comments
Closed
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug

Comments

@luabud
Copy link
Member

luabud commented Sep 25, 2019

To address #5764

if it isn't a Windows machine and if the selected interpreter is a conda environment and "terminal.integrated.inheritEnv" is not set on the user's user settings, we can prompt the message below:

"We noticed you're using a conda environment. If you are experiencing issues with this environment in the integrated terminal, we suggest the "terminal.integrated.inheritEnv" setting to be changed to false. Would you like to update this setting?"
Options: Yes, No

And add telemetry for the yes selection, so we can know if this is actually solving the issue.

@luabud luabud added feature-request Request for new features or functionality needs PR area-terminal triage-needed Needs assignment to the proper sub-team labels Sep 25, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 25, 2019
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Sep 25, 2019
@karthiknadig
Copy link
Member

karthiknadig commented Sep 25, 2019

If the user dismisses (the "X") we should show it again. The context of the setting is User Setting, and should apply to all work spaces.

@karthiknadig
Copy link
Member

Looks like inheritEnv is set by default, in user settings. This was from a fresh install of vscode:
image

@luabud
Copy link
Member Author

luabud commented Oct 10, 2019

Just to make sure everyone understands what is the issue, the prompt is being displayed for Windows users (and apparently not for Mac nor Linux) as you can see here: #7861
Whoever works on this, please can you change the wording to specify that the changes will be on the settings.json file in the prompt, as described in the issue above? i.e. "[...], we suggest the "terminal.integrated.inheritEnv" setting to be changed to false in the settings.json file. [...]"

@DonJayamanne
Copy link

setting to be changed to false in the settings.json file

Can I suggest we change as follows setting to be changed to false in the settings (settings.json file)

Novice users won't know what settings.json file is. VS Code has change the default settings configuration to a fancy UI and hidden the settings.json file behind the UI.

@kylekeppler
Copy link

I had to also run conda init powershell in the VS code powershell terminal. After running that once, the correct env is activated in the future when creating powershell terminals in VS code. (Conda 4.7.12, VS Code 1.38.2, Python Ext 2019.10.41019)

@karthiknadig
Copy link
Member

Verified on Linux:
image

@kimadeline
Copy link

Verified on Windows with 2019.11.42782-dev: Nothing appeared when opening a workspace and selecting a conda environment.

Closing this issue and #7733.

@ghost ghost removed the needs PR label Oct 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

7 participants