Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to get more info related to inheritEnv setting when prompt is dispalyed #7733

Closed
DonJayamanne opened this issue Oct 2, 2019 · 7 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@DonJayamanne
Copy link

As a user of VS Code I won't know what the setting inheritEnv is.
It would be good to add a button that the user could click to get more information.

Its just like any other prompt, LS does not work and we switch to Jedi, and we add a button where users can get more info about this.
E.g. what is LS and what is .NET core. Same here.

Screen Shot 2019-10-02 at 09 08 34

@DonJayamanne DonJayamanne added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Oct 2, 2019
@karrtikr
Copy link

karrtikr commented Oct 2, 2019

We might want to do this quickly because this is only a one-time prompt. We don't want to show this prompt again to the same User with More info button.

@DonJayamanne
Copy link
Author

We might want to do this quickly because this is only a one-time prompt. We don't want to show this prompt again with More info button.

Doesn't make sense. Personally I dont see any harm in adding the button for the benefit of the user.

As a user i don't know what inhertiEnv is! I will click no or go open my browser google this, find the right issue/blog that explains this and then come back.
Now open VS Code and the prompt has gone away!

@karrtikr
Copy link

karrtikr commented Oct 2, 2019

What I meant was that for the users who already have seen the prompt, we don't want to show the prompt again with More info button.
So we should get this in for this release so most users see the prompt you suggested (with the the More info button).

@karthiknadig karthiknadig added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR labels Oct 2, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 2, 2019
@DonJayamanne
Copy link
Author

we don't want to show the prompt again with More info button.

I'd always leave it in there.

@karthiknadig
Copy link
Member

See #7861 this did not work.

@luabud
Copy link
Member

luabud commented Oct 10, 2019

Interesting, it worked for me:
image

@kimadeline
Copy link

Since it worked for @luabud and @karthiknadig (see #7607 (comment)) I'm gonna mark this issue as ✅ validated ✅ and close it.

@ghost ghost removed the needs PR label Oct 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants