-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension shouldn't enable the "RedirectOutput" debug flag by default #8865
Comments
This overlapped with a bug in the most recent version of ptvsd that's bundled with the extension, whereby it doesn't properly flush redirected output. The result is that when the debugged app prints something, it's not immediately visible, and may not be visible at all unless the app prints enough. This is now fixed on ptvsd side, but until we can get a new build of that into the extension, it's a very annoying issue for any user who ends up in the new-ptvsd experiment. OTOH, fixing this issue will provide an immediate workaround. Should this be prioritized higher, @luabud? |
Yes good point, thanks. @brettcannon would you mind prioritizing this? 😁 |
@int19h we're about to cut for the release. The only higher priority is a P0 at this point. Is that how important this is? |
…ebug flag by default Don't enable "redirectOutput" unless "internalConsole" is specified.
…ebug flag by default Don't enable "redirectOutput" unless "internalConsole" is specified.
…ebug flag by default Don't enable "redirectOutput" unless "internalConsole" is specified.
…ebug flag by default (microsoft#9080) * Add debugger logs to .gitignore. * Fix microsoft#8865: Extension shouldn't enable the "RedirectOutput" debug flag by default Don't enable "redirectOutput" unless "internalConsole" is specified.
The extension currently forces it to be true unless it's explicitly set to false in launch.json. This overrides the new ptvsd default, which depends on the selected console type (true for "internalConsole", false for "integratedTerminal" and "externalTerminal").
vscode-python/src/client/debugger/extension/configuration/resolvers/attach.ts
Lines 68 to 70 in 967f7b1
This needs to be fixed to fix microsoft/ptvsd#1960
The text was updated successfully, but these errors were encountered: