Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension shouldn't enable the "RedirectOutput" debug flag by default #8865

Closed
int19h opened this issue Dec 2, 2019 · 3 comments
Closed
Assignees
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug

Comments

@int19h
Copy link

int19h commented Dec 2, 2019

The extension currently forces it to be true unless it's explicitly set to false in launch.json. This overrides the new ptvsd default, which depends on the selected console type (true for "internalConsole", false for "integratedTerminal" and "externalTerminal").

if (debugConfiguration.redirectOutput || debugConfiguration.redirectOutput === undefined) {
this.debugOption(debugOptions, DebugOptions.RedirectOutput);
}

This needs to be fixed to fix microsoft/ptvsd#1960

@int19h int19h added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Dec 2, 2019
@karthiknadig karthiknadig added area-debugging needs PR important Issue identified as high-priority and removed triage-needed Needs assignment to the proper sub-team labels Dec 3, 2019
@int19h
Copy link
Author

int19h commented Dec 12, 2019

This overlapped with a bug in the most recent version of ptvsd that's bundled with the extension, whereby it doesn't properly flush redirected output. The result is that when the debugged app prints something, it's not immediately visible, and may not be visible at all unless the app prints enough.

This is now fixed on ptvsd side, but until we can get a new build of that into the extension, it's a very annoying issue for any user who ends up in the new-ptvsd experiment. OTOH, fixing this issue will provide an immediate workaround. Should this be prioritized higher, @luabud?

@luabud
Copy link
Member

luabud commented Dec 12, 2019

Yes good point, thanks. @brettcannon would you mind prioritizing this? 😁

@brettcannon
Copy link
Member

@int19h we're about to cut for the release. The only higher priority is a P0 at this point. Is that how important this is?

@int19h int19h added P0 and removed important Issue identified as high-priority labels Dec 12, 2019
@int19h int19h self-assigned this Dec 12, 2019
int19h added a commit to int19h/vscode-python that referenced this issue Dec 12, 2019
…ebug flag by default

Don't enable "redirectOutput" unless "internalConsole" is specified.
int19h added a commit to int19h/vscode-python that referenced this issue Dec 12, 2019
…ebug flag by default

Don't enable "redirectOutput" unless "internalConsole" is specified.
int19h added a commit to int19h/vscode-python that referenced this issue Dec 12, 2019
…ebug flag by default

Don't enable "redirectOutput" unless "internalConsole" is specified.
@kimadeline kimadeline added this to the 2019 December Sprint 1 milestone Dec 13, 2019
@int19h int19h closed this as completed in 2536a97 Dec 13, 2019
@ghost ghost removed the needs PR label Dec 13, 2019
int19h pushed a commit to int19h/vscode-python that referenced this issue Dec 16, 2019
…ebug flag by default (microsoft#9080)

* Add debugger logs to .gitignore.

* Fix microsoft#8865: Extension shouldn't enable the "RedirectOutput" debug flag by default

Don't enable "redirectOutput" unless "internalConsole" is specified.
int19h pushed a commit that referenced this issue Dec 16, 2019
… by default (#9080) (#9141)

* Add debugger logs to .gitignore.

* Fix #8865: Extension shouldn't enable the "RedirectOutput" debug flag by default

Don't enable "redirectOutput" unless "internalConsole" is specified.
@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants