Modified Select interpreter command & add a reset interpreter command

[karrtikr]

I recommend to hide whitespace changes before reviewing

• Modified Select interpreter command to support setting interpreter at workspace level
• Added a reset interpreter command in a similar way

For #10372 #10374

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[codecov-io]

Codecov Report

Merging #10373 into pythonPath will increase coverage by <.01%.
The diff coverage is 76.92%.

@@              Coverage Diff               @@
##           pythonPath   #10373      +/-   ##
==============================================
+ Coverage       60.83%   60.83%   +<.01%     
==============================================
  Files             570      570              
  Lines           30746    30764      +18     
  Branches         4375     4379       +4     
==============================================
+ Hits            18704    18715      +11     
- Misses          11089    11094       +5     
- Partials          953      955       +2

Impacted Files	Coverage Δ
src/client/interpreter/configuration/types.ts	100% <ø> (ø)	⬆️
...guration/services/workspaceFolderUpdaterService.ts	25% <0%> (ø)	⬆️
...ter/configuration/services/globalUpdaterService.ts	12.5% <0%> (ø)	⬆️
...erpreter/configuration/pythonPathUpdaterService.ts	23.07% <0%> (ø)	⬆️
src/client/common/constants.ts	100% <100%> (ø)	⬆️
src/client/common/utils/localize.ts	95.09% <100%> (+0.01%)	⬆️
...t/interpreter/configuration/interpreterSelector.ts	70.58% <94.73%> (+5.37%)	⬆️
src/datascience-ui/react-common/arePathsSame.ts	75% <0%> (-12.5%)	⬇️
src/client/common/utils/platform.ts	64.7% <0%> (-11.77%)	⬇️
src/client/linters/pydocstyle.ts	86.66% <0%> (-2.23%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12c6bf...76ec498. Read the comment docs.

[ericsnowcurrently]

Mostly LGTM.

I do have a question about whether the workspace quickpick part should be part of this PR or not. It seems fine here, but if there is a separate issue for it then I'd expect a separate PR.

I also recommend renaming InterpreterSelector.getWorkspaceToSetPythonPath() to getConfigTarget() and make it handle the global case.

[ericsnowcurrently]

Why is this part of this PR? Each PR should cover one change, so shouldn't it be in a separate PR? If it really is integral to the reset interpreter command then I don't see why it should have a separate issue number.

[karrtikr]

Actually I had to refactor tests for Modified Select interpreter command to support setting interpreter at workspace level while writing tests for Added a reset interpreter command in a similar way.

I can move Added a reset interpreter command in a similar way it into a separate PR but it would still be based on Modified Select interpreter command to support setting interpreter at workspace level PR, so I figured maybe not. Should I do it?

[ericsnowcurrently]

There are several advantages to keeping each PR discrete. Some of those advantages:

• easier to understand
• easier to identify what changed in the git history
• easier to revert

At the least I wanted to understand why one PR was addressing 2 distinct issues, before I approved the PR.

[karrtikr]

I understand. I should've atleast left a comment explaining the reason I did that. Thanks for the feedback!

[ericsnowcurrently]

LGTM (assuming we sort out the question of one PR for multiple issues)

[karthiknadig]

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information