Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a prompt asking user to upgrade Code runner to new version to keep using it #11395

Merged
merged 2 commits into from
May 4, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 24, 2020

⚠ DON'T MERGE THIS UNTIL NEW CODE RUNNER EXTENSION IS RELEASED

For #11327

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@karrtikr karrtikr force-pushed the upgradeCoderunner branch 2 times, most recently from 9ca9fec to 9fa2e95 Compare April 24, 2020 19:33
@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #11395 into master will increase coverage by 0.04%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11395      +/-   ##
==========================================
+ Coverage   60.45%   60.50%   +0.04%     
==========================================
  Files         618      619       +1     
  Lines       33774    33829      +55     
  Branches     4763     4771       +8     
==========================================
+ Hits        20419    20468      +49     
- Misses      12347    12351       +4     
- Partials     1008     1010       +2     
Impacted Files Coverage Δ
...pplication/diagnostics/checks/upgradeCodeRunner.ts 96.07% <96.07%> (ø)
src/client/application/diagnostics/constants.ts 100.00% <100.00%> (ø)
.../client/application/diagnostics/serviceRegistry.ts 96.87% <100.00%> (+0.20%) ⬆️
src/client/common/utils/localize.ts 95.51% <100.00%> (+0.01%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0158c3...fccbe1a. Read the comment docs.

package.nls.json Outdated Show resolved Hide resolved
Kartik Raj added 2 commits May 4, 2020 02:05
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karrtikr karrtikr merged commit 87c4584 into microsoft:master May 4, 2020
@karrtikr karrtikr deleted the upgradeCoderunner branch May 4, 2020 09:49
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants