Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage ComponentAdapter.getInterpreterInformation in PythonPathUpdaterService #15134

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jan 12, 2021

For #12020

Outcome from discussion with Luciana:

I believe we added that to establish a baseline for what our users had. But we can ditch the architecture value with the updates we're making, so we don't need to run anything to discover the bitness.

and

As for the pipversion, do we know if there's a performance implication?
actually I don't remember using this info anywhere anyway, so let's ditch pipversion too

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Jan 12, 2021
@kimadeline kimadeline self-assigned this Jan 12, 2021
@kimadeline kimadeline added the skip tests Updates to tests unnecessary label Jan 12, 2021
@kimadeline kimadeline marked this pull request as ready for review January 12, 2021 23:39
@codecov-io
Copy link

Codecov Report

Merging #15134 (1cd761c) into main (4501ff5) will increase coverage by 0%.
The diff coverage is 11%.

@@          Coverage Diff           @@
##            main   #15134   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        561      561           
  Lines      26492    26511   +19     
  Branches    3789     3795    +6     
======================================
+ Hits       17243    17262   +19     
  Misses      8549     8549           
  Partials     700      700           
Impacted Files Coverage Δ
src/client/telemetry/index.ts 76% <ø> (ø)
...erpreter/configuration/pythonPathUpdaterService.ts 24% <11%> (+2%) ⬆️
...client/interpreter/virtualEnvs/virtualEnvPrompt.ts 78% <0%> (-7%) ⬇️
src/client/pythonEnvironments/legacyIOC.ts 35% <0%> (-2%) ⬇️
src/client/telemetry/constants.ts 100% <0%> (ø)
src/client/interpreter/contracts.ts 100% <0%> (ø)
...nments/base/locators/lowLevel/fsWatchingLocator.ts 84% <0%> (+30%) ⬆️

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit a06f21b into microsoft:main Jan 14, 2021
@kimadeline kimadeline deleted the python-updater-sendtelemetry branch January 14, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants