Fix python.poetryPath setting for installer on Windows
#15707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
force-pushed
the
poetryapht
branch
2 times, most recently
from
6ea1f09 to
782e4e0
Compare
karrtikr
commented
Mar 18, 2021
| try { | ||
| const processService = await this.processFactory.create(workfolder); | ||
| const execPath = this.configurationService.getSettings(workfolder).poetryPath; | ||
| const result = await processService.exec(execPath, ['list'], { cwd: workfolder.fsPath }); |
karthiknadig
approved these changes
Mar 18, 2021
kimadeline
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9672
Explanation: #9672 (comment)
PR was small enough so corrected ESLint errors in this PR itself.