Update Notebook API for the python extension side of things #15884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
requested review from
DonJayamanne,
joyceerhl,
rchiodo and
DavidKutu
rchiodo
approved these changes
Apr 7, 2021
DonJayamanne
approved these changes
Apr 7, 2021
joyceerhl
approved these changes
Apr 7, 2021
DavidKutu
approved these changes
Apr 7, 2021
karthiknadig
approved these changes
Apr 7, 2021
kimadeline
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the same changes seen in Jupyter here: microsoft/vscode-jupyter#5418
Mostly just change out .cells for getCells(), .cells.length for cellCount, and cells[x] for cellAt(x).