Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test view with a welcome button #16215

Merged
merged 2 commits into from
May 12, 2021

Conversation

karthiknadig
Copy link
Member

This PR will break testing and tests. This is intentional. This PR removes the old test view with a new one. for now, the new test view will be visible by default and will have a "Configure Python Tests" button. The content in the RED box is the content we can control (red box not part of the UI).
image

Note, that this PR will be merged to test-ui branch to avoid breaking testing in the main branch.

@karthiknadig karthiknadig added the no-changelog No news entry required label May 11, 2021
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

package.json Show resolved Hide resolved
@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label May 11, 2021
@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label May 12, 2021
@karthiknadig karthiknadig merged commit 0eb3828 into microsoft:test-ui May 12, 2021
karthiknadig added a commit that referenced this pull request May 17, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
@karthiknadig karthiknadig deleted the provide-config branch May 21, 2021 07:07
karthiknadig added a commit that referenced this pull request May 21, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karthiknadig added a commit that referenced this pull request Jun 9, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Jul 23, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Jul 26, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Jul 28, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Aug 2, 2021
* Add test view with a welcome button

* Register registerTestController only when available.
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Aug 5, 2021
* migrating User PR to test branch: Fix broken unittest test discovery (microsoft#16703)

* Fix broken unittest test discovery

Test discovery with unittest was not working at all. This is now fixed
with a more reliable method.  (Issue 16593)

* Fix typo

Somehow I managed to typo such a simple change.

Co-authored-by: Julian Edwards <bigjools@gmail.com>

* Remove code lenses used in tests (microsoft#16200)

* Add test view with a welcome button (microsoft#16215)

* Add test view with a welcome button

* Register registerTestController only when available.

* Remove nosetest support (microsoft#16217)

* Remove nosetest support

* Fix enablement tests

* Update src/client/testing/common/xUnitParser.ts

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

* Remove navigation commands (microsoft#16276)

* Removing view test ui and view test output commands (microsoft#16298)

* Remove test picker (microsoft#16300)

* Remove more test commands (microsoft#16314)

* Remove select and run commands

* Remove commands from package json

* Remove more test commands (microsoft#16315)

* Remove testing dependency on language server (microsoft#16319)

* Remove old test code (only configuration remains)

* Use new Test UI API from VS Code

* Move test configuration

* Fix linting

* Add news items

* Ensure controller is disposed

* Tweaks to get testing working on stable.

* Remove empty file.

* Fix some sonar issues

* Fix issue with pytest crashing on discovery

* Add force refresh on interpreter change.

* Handle large number of FS events

* Simplify triggering test refresh on config change

* VS Code API change to support errored state

* Ensure skipped status is set on unittest tests

* Adding code review suggestions

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

* Fix package json encoding issue

* Fix bad package.json merge

* Fix issues with multi-root workspace runs

* Tweak multi-root support and failed test reruns

* Fix package json encoding

* Fix linting

* Add refresh and run failed icons

* Trigger discovery on settings change, and show discovery errors

* Fix encoding from windows-1252 to utf-8

* Better messaging when pytest is not installed

* Improve handling of failure expected and pass unexpected

* Add news items

* Add more news items.

Co-authored-by: Julian Edwards <bigjools@gmail.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants