Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12373: Added a new Debug setting named "VariablePresentation" #17587

Closed
wants to merge 4 commits into from

Conversation

arsentieva
Copy link

@arsentieva arsentieva commented Oct 1, 2021

Added new setting to package.json named VariablePresentation that will allow the user the configure how the variables are presented during debug sessions.

The parameters are:

  • All
  • Class
  • Function
  • Protected
  • Special

Each of these parameters provide the following options:

  • inline
  • group
  • hide

Closes microsoft/vscode-python-debugger#165

@ghost
Copy link

ghost commented Oct 1, 2021

CLA assistant check
All CLA requirements met.

@karthiknadig karthiknadig changed the base branch from main to OSD October 1, 2021 19:44
@karthiknadig
Copy link
Member

@arsentieva I am basing this to OSD branch. Since we are preparing main for release.

@karthiknadig
Copy link
Member

@arsentieva Please add a news item so that you get credit for this change. The change itself looks good.

@arsentieva arsentieva changed the title Added a new Debug setting named "VariablePresentation" Issue #12373: Added a new Debug setting named "VariablePresentation" Oct 1, 2021
@karthiknadig
Copy link
Member

@arsentieva Will you be updating the TS parts as well? The setting itself looks fine but it won't get propagated to the debugger. For that you will need to make updates as recommended here microsoft/vscode-python-debugger#165

@arsentieva
Copy link
Author

@karthiknadig I would like to make that enhancement, however I am not familiar with Typescript as well as not not 100% sure what needs to be done.

@karthiknadig
Copy link
Member

@arsentieva If you think you can get to this later, you can leave this open. Otherwise, we can close this for now, and you can try again when you have better handle on TypeScript?

@arsentieva
Copy link
Author

@luabud can you please help me understand what was the goal of this issue? According to our conversation it sounded like it needed a setting in the package.json.

@karthiknadig
Copy link
Member

@arsentieva This one needs some changes in the settings code and the debug resolver to send this setting to the debug adapter.

@karthiknadig
Copy link
Member

Closing this since this might require more discussion to correctly address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants