Upgrade to latest jupyter lsp and skip intellisense when inside a cell #17734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
added
no-changelog
DonJayamanne
approved these changes
Oct 14, 2021
|
@paulacamargo25 did you have any feedback? Thanks. |
|
Jupyter side of this has been submitted. When the next jupyter insiders goes out, we'll have dupe intellisense in notebooks until this PR goes through. |
|
No, looks good to me, i'm just checking why some test are failing |
|
Updating to latest main bits. Looked like there were errors in some Terminal tests (which shouldn't have been impacted by the changes in this pr) |
|
@paulacamargo25 the tests that are failing are also failing in other PRs. See this one here: Can we submit this change over the failures? |
|
Yes, im gonna merge the pr, thanks @rchiodo |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
microsoft/vscode-python#17734) * Upgrade to latest jupyter lsp and skip intellisense when inside a cell * Update package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a counter part to this PR: microsoft/vscode-jupyter#7924 this PR removes notebook intellisense from the python extension.