Skip to content

Fixes to the LS no reload work #18984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2022
Merged

Fixes to the LS no reload work #18984

merged 4 commits into from
Apr 22, 2022

Conversation

kimadeline
Copy link

Follow-up to #18884

  • Remove refCountedLanguageServer.ts
  • Multiroot: Dispose of the language server associated to a workspace folder if the folder was removed and we're using Jedi
  • Multiroot: Instantiate multiple language servers if in a multiroot scenario and using Jedi, only instantiate one language server in other cases

@kimadeline kimadeline added the no-changelog No news entry required label Apr 22, 2022
@kimadeline kimadeline self-assigned this Apr 22, 2022
@kimadeline kimadeline merged commit 4e20c2b into microsoft:main Apr 22, 2022
@kimadeline kimadeline deleted the 18509-lsp-noreload-fixes branch April 22, 2022 21:16
@kimadeline kimadeline mentioned this pull request Apr 25, 2022
Merged
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@kimadeline @wesm
Fixes to the LS no reload work (microsoft/vscode-python#18984)
d9015b0 
* Delete refCountedLanguageServer.ts

* Stop LS is workspace folder removed

* Only one LS for Pylance and None

* Dispose LS in multiroot scenario only with Jedi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kimadeline kimadeline

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kimadeline