Skip to content

Do not restart language server for Pylance on interpreter change #19425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Do not restart language server for Pylance on interpreter change #19425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e341158
Do not fire interpreter change events twice when global scope is modi…
Jul 7, 2022
9aca046
Do not restart language server for Pylance on interpreter change
Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/client/common/interpreterPathService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class InterpreterPathService implements IInterpreterPathService {
const globalValue = pythonConfig.inspect<string>('defaultInterpreterPath')!.globalValue;
if (globalValue !== pythonPath) {
await pythonConfig.update('defaultInterpreterPath', pythonPath, true);
this._didChangeInterpreterEmitter.fire({ uri: undefined, configTarget });
}
return;
}
Expand Down
4 changes: 4 additions & 0 deletions src/client/languageServer/watcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@ export class LanguageServerWatcher

// Watch for interpreter changes.
private async onDidChangeInterpreter(event: InterpreterConfigurationScope): Promise<void> {
if (this.languageServerType === LanguageServerType.Node) {
// Pylance client already handles interpreter changes, so restarting LS can be skipped.
return Promise.resolve();
}
// Reactivate the language server (if in a multiroot workspace scenario, pick the correct one).
return this.activate(event.uri);
}
Expand Down