Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lookup for new environments detected faster #19922

Merged
merged 7 commits into from
Oct 12, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Sep 29, 2022

Closes #19900

Trigger a scoped refresh instead of a full refresh when an environment gets created, preferably only looking for the environment which gets created.

@karrtikr karrtikr closed this Oct 6, 2022
@karrtikr karrtikr reopened this Oct 6, 2022
@karrtikr karrtikr added the feature-request Request for new features or functionality label Oct 6, 2022
@karrtikr karrtikr changed the title Trigger a scoped refresh instead of a full refresh when an environment gets created Make lookup for new environments detected faster Oct 6, 2022
@karrtikr karrtikr marked this pull request as ready for review October 6, 2022 22:32
karthiknadig
karthiknadig previously approved these changes Oct 11, 2022
@karrtikr
Copy link
Author

@karthiknadig Pinging for re-review.

@karrtikr karrtikr merged commit 76f7763 into microsoft:main Oct 12, 2022
@karrtikr karrtikr deleted the scopedrefresh branch October 12, 2022 17:12
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…thon#19922)

Closes microsoft/vscode-python#19900

Trigger a scoped refresh instead of a full refresh when an environment
gets created, preferably only looking for the environment which gets
created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new Conda Env creates a ton of calls to onDidChangeEnvironments
2 participants