Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to using conda run for fetching activated environment variables #19986

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Oct 11, 2022

Reverts #19819 Closes #19967

Until we have a better activation story: #11039, where we potentially get rid of using conda activate commands, use conda run for fetching environment variables even though it's slower.

Created #19987 for tackling it in the future.

FYI @DonJayamanne

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Oct 11, 2022
@karrtikr karrtikr closed this Oct 11, 2022
@karrtikr karrtikr reopened this Oct 11, 2022
@karrtikr karrtikr merged commit 38d8d9c into main Oct 12, 2022
@karrtikr karrtikr deleted the revert-19819-condaactiv branch October 12, 2022 17:13
karrtikr pushed a commit that referenced this pull request Oct 12, 2022
…les (#19986)

Reverts #19819 Closes
#19967

Until we have a better activation story:
#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created #19987 for
tackling it in the future.

FYI @DonJayamanne
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…les (microsoft/vscode-python#19986)

Reverts microsoft/vscode-python#19819 Closes
microsoft/vscode-python#19967

Until we have a better activation story:
microsoft/vscode-python#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created microsoft/vscode-python#19987 for
tackling it in the future.

FYI @DonJayamanne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Tensorboard can't open after VSCode's update
2 participants