Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve shell detector with customized terminal.integrated.defaultProfile/profiles #20428

Closed
wants to merge 1 commit into from

Conversation

Qusic
Copy link
Member

@Qusic Qusic commented Dec 23, 2022

  1. terminal.name can returns '' when terminal activation callback is called and will change to correct value later. however the user can use overrideName to set the value of terminal.creationOptions.name to the shell profile name.
  2. terminal.integrated.shell is deprecated but takes precedence over terminal.integrated.defaultProfile.

here are my setup on windows 11. currently detectors will all fail and fallback to powershell.exe in UserEnvironmentShellDetector.

  "terminal.integrated.defaultProfile.windows": "msvc-gitbash",
  "terminal.integrated.profiles.windows": {
    "msvc-gitbash": {
      "overrideName": true,
      "path": "path\\to\\script.bat"
    }
  }
@echo off
call "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat" > NUL
"C:\Program Files\Git\bin\sh.exe" -i -l

@karrtikr
Copy link

karrtikr commented Jan 7, 2023

Thanks for the PR. However this shell detector is no longer used and is basically dead code: #16023. We plan to remove all other detectors other than the VSCode one, hence closing this.

@karrtikr karrtikr closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants