Make auto indent depend on formatOnType setting value #20490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
added
the
bug
brettcannon
approved these changes
Jan 11, 2023
karrtikr
reviewed
Jan 11, 2023
| return inExperiment && formatOnTypeEffectiveValue; | ||
| const formatOnTypeEffectiveValue = this.getPythonSpecificEditorSection().get(FORMAT_ON_TYPE_CONFIG_SETTING); | ||
|
|
||
| return formatOnTypeEffectiveValue; | ||
| } | ||
|
|
||
| private async isInAutoIndentExperiment(): Promise<boolean> { |
There was a problem hiding this comment.
We're still checking for inExperiment, so can you clarify how are we making sure this is enabled for all users? cc/ @luabud
There was a problem hiding this comment.
We don't want to enable this to all users, just those who explicitly enable format on type. If they don't have it enabled, we still want only those who are in the experiment to experience it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20479
Another fix for recovery release.