Detect ActiveState Python runtimes #20534

mitchell-as · 2023-01-19T20:29:21Z

Closes #20532

mitchell-as · 2023-01-20T15:20:44Z

@microsoft-github-policy-service agree company=“ActiveState"

karrtikr

Thanks for the comprehensive PR, great work! Almost there.

src/client/pythonEnvironments/common/environmentManagers/activestate.ts

src/client/pythonEnvironments/base/locators/composite/resolverUtils.ts

src/client/pythonEnvironments/base/info/index.ts

src/client/pythonEnvironments/base/locators/composite/resolverUtils.ts

src/client/pythonEnvironments/base/info/envKind.ts

src/test/pythonEnvironments/common/environmentManagers/activestate.unit.test.ts

src/client/pythonEnvironments/common/environmentManagers/activestate.ts

karrtikr

Follow up: Is it there a cheaper way to check whether ActiveState is installed, rather than running the binary? Perhaps check a standard file location first, or a registry key.

The concern is to avoid running this for every session, if the probability of us finding it is less.

Try to avoid running the `state` binary, as it's expensive. If its installation path does not exist, it is not installed.

mitchell-as · 2023-01-23T21:47:54Z

Follow up: Is it there a cheaper way to check whether ActiveState is installed, rather than running the binary? Perhaps check a standard file location first, or a registry key.

The concern is to avoid running this for every session, if the probability of us finding it is less.

Yes, I have committed changes to look for an installation of our tool on the local filesystem. If there is no installation, then no attempt will be made to detect our runtimes (and thus no shell execute).

src/client/pythonEnvironments/base/info/envKind.ts

src/client/pythonEnvironments/common/environmentManagers/activestate.ts

src/test/pythonEnvironments/common/environmentManagers/activestate.unit.test.ts

src/client/pythonEnvironments/common/environmentManagers/activestate.ts

…ociated with.

mitchell-as · 2023-01-25T21:01:23Z

One more addition: in the event that the user would like to specify the path to our tool on the local filesystem, I've added a preference to do so.

…ool.

mitchell-as · 2023-02-02T16:37:29Z

Thanks for all of your time and feedback so far. I really appreciate it.

karrtikr

Looks good to me! Thanks for working through all the comments, feel free to let us know if you need anything more.

Use a more descriptive name.

karrtikr · 2023-02-07T19:00:58Z

Lint appears to be failing, this will need to be updated using main branch as well.

mitchell-as · 2023-02-07T21:57:28Z

Lint seems to be fixed now.

-------------------- Commit message for microsoft/vscode-python@fc72be9: Show `Python: Report issue` command in palette regardless of whether a Python file is opened (microsoft/vscode-python#20726) Closes microsoft/vscode-python#20723 -------------------- Commit message for microsoft/vscode-python@c18e8c9: Detect ActiveState Python runtimes (microsoft/vscode-python#20534) Closes microsoft/vscode-python#20532 -------------------- Commit message for microsoft/vscode-python@2152cd9: Don't set `formatOnType` for auto-indent experiment if it's already set (microsoft/vscode-python#20710) -------------------- Commit message for microsoft/vscode-python@995b0bc: Add support for 'back' to all create env UI. (microsoft/vscode-python#20693) Closes microsoft/vscode-python#20274 ### Usage This change allows callers of the Create Environment command to handle `Back` and `Cancel`: ``` typescript let result: CreateEnvironmentResult | undefined; try { const result = await commands.executeCommand("python.createEnvironment", {showBackButton: true}); } catch(e) { // error while creating environment } if (result?.action === 'Back') { // user clicked Back } if (result?.action === 'Cancel') { // user pressed escape or Cancel } ``` I decided to go with `result?.action` because we don't have a npm package for python extension API so catching particular exception might be error prone with `ex instanceof <error>`. We will provide a proper interface via `api.environments` for create environment, and contribution to create environment. Until that point this command will provide the stop gap. ### Notes 1. I did not use the multi-step input that is used in the rest of the extension because, the existing implementation does not have context. Consider the following scenario: venv -> workspace select -> python select -> packages. Assume that there is only one workspace, and we don't show the workspace selection UI, that decision is done inside the workspace step. So, if there is only 1 workspace it is a short circuit to next step. User is on python selection and clicks `back`, workspace selection short circuits to next step which is python selection. So, from user perspective, back does not work. This can be fixed by sending context that the reason control moved to previous step was because user clicked on back. 2. This makes a change to old multi step API to rethrow the exception, if user hits `back` and the current step has no steps to go back to. -------------------- Commit message for microsoft/vscode-python@f3ecbf5: Fix-conda-version-parsing (microsoft/vscode-python#20674) -------------------- Commit message for microsoft/vscode-python@a6a6f50: Inactive pytest run command (microsoft/vscode-python#20653) Here the new flow is created but kept inactive for the pytest execution -------------------- Commit message for microsoft/vscode-python@2202fbe: Call the correct API to determine if a user is in treatment or control group (microsoft/vscode-python#20690) Closes microsoft/vscode-python#20183 -------------------- Commit message for microsoft/vscode-python@b0ab10d: Only use activated environment from terminal if VSCode was launched via CLI (microsoft/vscode-python#20667) Closes microsoft/vscode-python#20644 -------------------- Commit message for microsoft/vscode-python@02a92fc: Ensure interpreter path isn't truncated for workspace-relative paths when storing value (microsoft/vscode-python#20661) For microsoft/vscode-python#20660 I'm not quite sure why this was done. It doesn't make sense to do this only for display. -------------------- Commit message for microsoft/vscode-python@377067f: Use correct API to get interpreter path for language servers (microsoft/vscode-python#20656) For microsoft/vscode-python#20644 closes microsoft/vscode-python#20657 -------------------- Commit message for microsoft/vscode-python@cd6ca9d: Remove `isort` extension dependency (microsoft/vscode-python#20577) Closes microsoft/vscode-python#20586 Lead-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Erik De Bonte <erikd@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: mitchell <mitchellb@activestate.com> Co-authored-by: Pete Farland <pete.farland@posit.co> Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>

mitchell-as marked this pull request as ready for review January 19, 2023 20:40

mitchell-as force-pushed the main branch from 573c13f to 185ed5c Compare January 19, 2023 21:08

karthiknadig requested a review from karrtikr January 21, 2023 01:54

karthiknadig assigned karrtikr Jan 21, 2023

mitchell-as force-pushed the main branch from 185ed5c to fe3e69d Compare January 23, 2023 17:29

Detect ActiveState Python runtimes (microsoft#20532)

d6ba0a7

mitchell-as force-pushed the main branch from fe3e69d to d6ba0a7 Compare January 23, 2023 17:56

Attempt to fix Windows test failure.

3381fe5

karrtikr suggested changes Jan 23, 2023

View reviewed changes

karrtikr added the feature-request Request for new features or functionality label Jan 23, 2023

karrtikr changed the title ~~Detect ActiveState Python runtimes (#20532)~~ Detect ActiveState Python runtimes Jan 23, 2023

karrtikr reviewed Jan 23, 2023

View reviewed changes

mitchell-as added 5 commits January 23, 2023 16:14

Fixed invalid JSON in unit test.

b768ae6

Reduce state command timeout.

625dd7c

Address some PR feedback.

951d522

Improve ActiveState State Tool detection.

b62dd06

Try to avoid running the `state` binary, as it's expensive. If its installation path does not exist, it is not installed.

Addressing more PR feedback.

97a0b57

karrtikr reviewed Jan 24, 2023

View reviewed changes

mitchell-as added 5 commits January 24, 2023 14:51

Remove unnecessary IFilesystem mocks.

819d16f

Mock up an ActiveState State Tool installation in tests.

1850c13

Recommend ActiveState Python runtimes for the workspaces they are ass…

29633fa

…ociated with.

Fixed failing unit test by checking for defined interpreter path.

1a0d3c4

Added preference for specifying path to ActiveState's State Tool.

1d135ae

mitchell-as requested a review from karrtikr January 25, 2023 21:03

mitchell-as added 3 commits January 31, 2023 13:15

Fixed failing Windows unit test.

31545bd

Merge branch 'main' into main

b219494

Merge branch 'main' into main

3ef7cd6

Revert: Added preference for specifying path to ActiveState's State T…

e90ae16

…ool.

mitchell-as requested a review from karrtikr February 2, 2023 16:37

karrtikr previously approved these changes Feb 2, 2023

View reviewed changes

karrtikr requested a review from karthiknadig February 2, 2023 19:32

karthiknadig previously approved these changes Feb 2, 2023

View reviewed changes

mitchell-as added 2 commits February 3, 2023 15:28

Merge remote-tracking branch 'upstream/main'

97f6740

Re-added preference for specifying path to ActiveState's State Tool.

b5595b2

Use a more descriptive name.

mitchell-as dismissed stale reviews from karthiknadig and karrtikr via b5595b2 February 7, 2023 18:48

mitchell-as requested review from brettcannon and karrtikr and removed request for brettcannon and karrtikr February 7, 2023 18:52

mitchell-as added 2 commits February 7, 2023 14:38

Merge remote-tracking branch 'upstream/main'

8ade316

Fix lint error.

6eb0ac3

karrtikr added the skip package*.json package.json and package-lock.json don't both need updating label Feb 8, 2023

karrtikr approved these changes Feb 8, 2023

View reviewed changes

karrtikr requested a review from karthiknadig February 8, 2023 12:57

karthiknadig approved these changes Feb 13, 2023

View reviewed changes

karthiknadig enabled auto-merge (squash) February 22, 2023 00:08

karthiknadig approved these changes Feb 22, 2023

View reviewed changes

karthiknadig merged commit c18e8c9 into microsoft:main Feb 22, 2023

This was referenced Feb 27, 2024

Add locator for pixi environments #22968

Merged

Add support for Hatch environments #22779

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect ActiveState Python runtimes #20534

Detect ActiveState Python runtimes #20534

mitchell-as commented Jan 19, 2023 •

edited by karrtikr

Loading

mitchell-as commented Jan 20, 2023 via email

karrtikr left a comment

karrtikr left a comment

mitchell-as commented Jan 23, 2023

mitchell-as commented Jan 25, 2023

mitchell-as commented Feb 2, 2023

karrtikr left a comment •

edited

Loading

karrtikr commented Feb 7, 2023

mitchell-as commented Feb 7, 2023

Detect ActiveState Python runtimes #20534

Detect ActiveState Python runtimes #20534

Conversation

mitchell-as commented Jan 19, 2023 • edited by karrtikr Loading

mitchell-as commented Jan 20, 2023 via email

karrtikr left a comment

Choose a reason for hiding this comment

karrtikr left a comment

Choose a reason for hiding this comment

mitchell-as commented Jan 23, 2023

mitchell-as commented Jan 25, 2023

mitchell-as commented Feb 2, 2023

karrtikr left a comment • edited Loading

Choose a reason for hiding this comment

karrtikr commented Feb 7, 2023

mitchell-as commented Feb 7, 2023

mitchell-as commented Jan 19, 2023 •

edited by karrtikr

Loading

karrtikr left a comment •

edited

Loading