Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Ensure both python and pythonPath are not set when resolving config #20801

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

karthiknadig
Copy link
Member

Fixes #20655

Cherry pick from main to release

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Mar 6, 2023
@karthiknadig karthiknadig self-assigned this Mar 6, 2023
@karthiknadig karthiknadig marked this pull request as ready for review March 6, 2023 20:12
@karthiknadig karthiknadig merged commit 38c2111 into microsoft:release/2023.04 Mar 7, 2023
@karthiknadig karthiknadig deleted the cherry1 branch March 7, 2023 17:27
@vicizmax
Copy link

vicizmax commented May 9, 2023

Hey @karthiknadig ! I'm doing a research case for school and trying to gather user insights to understand open source and, specifically code quality tools. I noticed in this project that you were using SonarCloud Code Analysis until this PR. Any chance you might be willing to share why you stopped using it in this project? :) I am trying to identify the needs and motivations of OSS developers for using particular code quality tools and what makes them switch!

@karthiknadig
Copy link
Member Author

We were not getting additional benefits from SonarCloud, we run eslint, CodeQL, several internal tools to give us signal on code quality. We also had issues with false positives with SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants