Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo with clientOS #20819

Merged
merged 1 commit into from
Mar 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ export class AttachConfigurationResolver extends BaseConfigurationResolver<Attac
(item, pos) => dbgConfig.debugOptions!.indexOf(item) === pos,
);
}
if (debugConfiguration.clienOS === undefined) {
if (debugConfiguration.clientOS === undefined) {
debugConfiguration.clientOS = getOSType() === OSType.Windows ? 'windows' : 'unix';
}
return debugConfiguration;
@@ -80,7 +80,7 @@ export class AttachConfigurationResolver extends BaseConfigurationResolver<Attac
if (getOSType() === OSType.Windows && isLocalHost) {
AttachConfigurationResolver.debugOption(debugOptions, DebugOptions.FixFilePathCase);
}
if (debugConfiguration.clienOS === undefined) {
if (debugConfiguration.clientOS === undefined) {
debugConfiguration.clientOS = getOSType() === OSType.Windows ? 'windows' : 'unix';
}
if (debugConfiguration.showReturnValue) {
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ export abstract class BaseConfigurationResolver<T extends DebugConfiguration>
debugConfiguration: DebugConfiguration,
_token?: CancellationToken,
): Promise<T | undefined> {
if (debugConfiguration.clienOS === undefined) {
if (debugConfiguration.clientOS === undefined) {
debugConfiguration.clientOS = getOSType() === OSType.Windows ? 'windows' : 'unix';
}
return debugConfiguration as T;
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ export class LaunchConfigurationResolver extends BaseConfigurationResolver<Launc

const workspaceFolder = LaunchConfigurationResolver.getWorkspaceFolder(folder);
await this.resolveAndUpdatePaths(workspaceFolder, debugConfiguration);
if (debugConfiguration.clienOS === undefined) {
if (debugConfiguration.clientOS === undefined) {
debugConfiguration.clientOS = getOSType() === OSType.Windows ? 'windows' : 'unix';
}
return debugConfiguration;
1 change: 1 addition & 0 deletions src/client/debugger/types.ts
Original file line number Diff line number Diff line change
@@ -59,6 +59,7 @@ interface ICommonDebugArguments {
subProcess?: boolean;
// An absolute path to local directory with source.
pathMappings?: PathMapping[];
clientOS?: 'windows' | 'unix';
}
interface IKnownAttachDebugArguments extends ICommonDebugArguments {
workspaceFolder?: string;