Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote resolver #21332

Merged
merged 18 commits into from
Jun 12, 2023
Merged

Remote resolver #21332

merged 18 commits into from
Jun 12, 2023

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented May 30, 2023 •
edited
Loading

This is branch will serve as a feature branch for all changes related to switching to the remote resolver.
This will include

  • switching from using the testAdapter to parse the return data to now using this new class resultResolver
  • adding tests for all testAdapters, fixing for server and adding for resultResolver
  • moving sendCommand to a new file, out of the server, and getting pytest to adopt it
  • moving the server which send the test IDs to a new file and adopt it for both pytest and unittest
  • write tests for these two new files.

@eleanorjboyd eleanorjboyd self-assigned this May 31, 2023
@eleanorjboyd eleanorjboyd added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jun 8, 2023
@eleanorjboyd
Copy link
Member Author

tests written so far:

  • pytestDiscoveryAdapter
    - discovery should call exec with correct basic args
    - discovery should pull from setting to get pytest args
  • pytestExecutionAdapter
    - pytest execution called with correct args
    - Debug launched correctly for pytest
  • testDiscoveryAdapter (unittest)
    - discovery should call sendCommand with correct basic args

@eleanorjboyd eleanorjboyd changed the base branch from main to resultResolver-feature-branch June 9, 2023 20:50
@eleanorjboyd eleanorjboyd marked this pull request as ready for review June 9, 2023 20:50
@eleanorjboyd eleanorjboyd requested review from karthiknadig, kimadeline, anthonykim1 and paulacamargo25 and removed request for kimadeline June 9, 2023 20:50
@eleanorjboyd eleanorjboyd mentioned this pull request Jun 9, 2023
Merged
@eleanorjboyd eleanorjboyd merged commit 8cec0fc into microsoft:resultResolver-feature-branch Jun 12, 2023
@eleanorjboyd eleanorjboyd deleted the remote-resolver branch June 12, 2023 18:15
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 12, 2023
@eleanorjboyd
Remote resolver (microsoft#21332)
4bd1d0b 
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
@eleanorjboyd
Remote resolver (microsoft#21332)
f4da1c4 
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
@eleanorjboyd
Remote resolver (microsoft#21332)
b84fb74 
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
@eleanorjboyd
Remote resolver (microsoft#21332)
1fa950d 
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
@eleanorjboyd
Remote resolver (microsoft#21332)
8cb9c93 
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 Awaiting requested review from anthonykim1

@paulacamargo25 paulacamargo25 Awaiting requested review from paulacamargo25

Assignees

@eleanorjboyd eleanorjboyd

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eleanorjboyd @karthiknadig